diff options
| author | Karthikeyan Ramasubramanian <kramasub@chromium.org> | 2021-10-25 23:26:25 -0600 |
|---|---|---|
| committer | Raul Rangel <rrangel@chromium.org> | 2021-10-27 22:03:56 +0000 |
| commit | 30c441fc2d7ffbc3acddc3339c3c5cfc0473ef0f (patch) | |
| tree | 51a5f536d9f555a925d39ede2619a77b00b07126 | |
| parent | 750abb1fe7ffcc9e90c60617cd42bb108a82168b (diff) | |
mb/google/guybrush: Remove WWAN_DISABLE GPIO
In-band controls work to enable/disable the WWAN module. Hence
WWAN_DISABLE_GPIO is not critical and can be marked as not connected.
BUG=b:188415287
TEST=Build and boot to OS in Guybrush. Ensure that the WWAN module is
enumerated on boot and reboot.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Change-Id: I7fefba3de9c749971911b21ed4712e950cef5a6a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
| -rw-r--r-- | src/mainboard/google/guybrush/variants/baseboard/gpio.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index c45d3a78ce..7062f42dd5 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -95,8 +95,8 @@ static const struct soc_amd_gpio base_gpio_table[] = { /* GPIO_77 - GPIO_83: Not available */ /* EC_SOC_INT_ODL */ PAD_GPI(GPIO_84, PULL_NONE), - /* WWAN_DISABLE */ - PAD_GPO(GPIO_85, LOW), + /* Unused */ + PAD_NC(GPIO_85), /* ESPI_SOC_CLK */ PAD_NF(GPIO_86, SPI_CLK, PULL_NONE), /* RAM_ID_1 / DEV_BEEP_DATA */ @@ -198,8 +198,6 @@ static const struct soc_amd_gpio early_gpio_table[] = { /* Put WWAN into reset */ /* WWAN_RST_L */ PAD_GPO(GPIO_24, LOW), - /* WWAN_DISABLE */ - PAD_GPO(GPIO_85, HIGH), /* Enable ESPI, GSC Interrupt & I2C Communication */ /* GSC_SOC_INT_L */ @@ -261,8 +259,6 @@ static const struct soc_amd_gpio bootblock_gpio_table[] = { /* Enable WWAN, Deassert WWAN reset, keep WWAN PCIe Aux reset asserted */ /* WWAN_RST_L */ PAD_GPO(GPIO_24, HIGH), - /* WWAN_DISABLE */ - PAD_GPO(GPIO_85, LOW), /* Enable WLAN */ /* WLAN_DISABLE */ |