summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Chen <robert.chen@quanta.corp-partner.google.com>2023-07-23 22:54:55 -0400
committerFelix Held <felix-coreboot@felixheld.de>2023-07-26 13:26:08 +0000
commit2d2815a7c224195e21e15c3e35c5343381918539 (patch)
treeaa649869d0899f73f06eedba21acb1f9c85621d0
parent69ffebf5ccf123bc0b3fb28b485985af0597761d (diff)
mb/google/nissa/var/yavilla: avoid mipi camera LED blinking during launch
Camera LED will blink several times as sensor is being probed during kernel boot. Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips initial probe during kernel boot and prevent privacy LED blink. BUG=b:292173903 TEST=Build and boot on Yavilly EVT unit. Verify & observe Camera LED blinking behavior. Change-Id: Ic3e3439dc9313325189761b277e1a3bd1c1d9418 Signed-off-by: Robert Chen <robert.chen@quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76671 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Derek Huang <derekhuang@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/brya/variants/yavilla/overridetree.cb4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/mainboard/google/brya/variants/yavilla/overridetree.cb b/src/mainboard/google/brya/variants/yavilla/overridetree.cb
index ede4e54b9b..12a26c26f8 100644
--- a/src/mainboard/google/brya/variants/yavilla/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yavilla/overridetree.cb
@@ -264,6 +264,7 @@ chip soc/intel/alderlake
register "chip_name" = ""Ov 8856 Camera""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "has_power_resource" = "1"
+ register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "1"
@@ -307,7 +308,6 @@ chip soc/intel/alderlake
register "chip_name" = ""DW AF DAC""
register "device_type" = "INTEL_ACPI_CAMERA_VCM"
- register "pr0" = ""\\_SB.PCI0.I2C2.CAM0.PRIC""
register "vcm_compat" = ""dongwoon,dw9714""
device i2c 0C on
@@ -321,8 +321,6 @@ chip soc/intel/alderlake
register "chip_name" = ""GT24C08""
register "device_type" = "INTEL_ACPI_CAMERA_NVM"
- register "pr0" = ""\\_SB.PCI0.I2C2.CAM0.PRIC""
-
register "nvm_size" = "0x2000"
register "nvm_pagesize" = "1"
register "nvm_readonly" = "1"