summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Nien <finaljason@gmail.com>2022-08-17 17:04:44 -0500
committerFelix Held <felix-coreboot@felixheld.de>2022-10-21 14:45:11 +0000
commit29f158008686f4c46a26ac4daa246755e70e2e4f (patch)
treee045abe6ff33bffe476721e44359abc67d8d40e7
parent4c0299fbc8514b62274b82861d665acc728d0ae0 (diff)
mb/google/skyrim/port_descriptors: update DDI for MDN and Chausie
Add two new types for MDN DDI descriptor BUG=b:228284940 TEST=Normal boot and S0i3 cycles Signed-off-by: Jason Nien <finaljason@gmail.com> Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/66847 Reviewed-by: Bao Zheng <fishbaozi@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Nikolai Vyssotski <nikolai.vyssotski@amd.corp-partner.google.com>
-rw-r--r--src/mainboard/amd/chausie/port_descriptors.c4
-rw-r--r--src/mainboard/google/skyrim/port_descriptors.c4
-rw-r--r--src/vendorcode/amd/fsp/mendocino/platform_descriptors.h4
3 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/amd/chausie/port_descriptors.c b/src/mainboard/amd/chausie/port_descriptors.c
index 17091e780e..b10abfa4d2 100644
--- a/src/mainboard/amd/chausie/port_descriptors.c
+++ b/src/mainboard/amd/chausie/port_descriptors.c
@@ -61,12 +61,12 @@ static fsp_ddi_descriptor chausie_ddi_descriptors[] = {
.hdp_index = DDI_HDP2
},
{ /* DDI2 - DP (type C) */
- .connector_type = DDI_DP,
+ .connector_type = DDI_DP_W_TYPEC,
.aux_index = DDI_AUX3,
.hdp_index = DDI_HDP3,
},
{ /* DDI3 - DP (type C) */
- .connector_type = DDI_DP,
+ .connector_type = DDI_DP_W_TYPEC,
.aux_index = DDI_AUX4,
.hdp_index = DDI_HDP4,
},
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c
index 808d00b5fe..91316b388c 100644
--- a/src/mainboard/google/skyrim/port_descriptors.c
+++ b/src/mainboard/google/skyrim/port_descriptors.c
@@ -61,12 +61,12 @@ static const fsp_ddi_descriptor skyrim_mdn_ddi_descriptors[] = {
.hdp_index = DDI_HDP2
},
{ /* DDI2 - DP (type C) */
- .connector_type = DDI_DP,
+ .connector_type = DDI_DP_W_TYPEC,
.aux_index = DDI_AUX3,
.hdp_index = DDI_HDP3,
},
{ /* DDI3 - DP (type C) */
- .connector_type = DDI_DP,
+ .connector_type = DDI_DP_W_TYPEC,
.aux_index = DDI_AUX4,
.hdp_index = DDI_HDP4,
},
diff --git a/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h b/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h
index 7dae872f2d..a8fb2575e1 100644
--- a/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h
+++ b/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h
@@ -142,8 +142,8 @@ enum ddi_connector_type {
DDI_DP_TO_LVDS, // DP-to-LVDS
DDI_NUTMEG_DP_TO_VGA, // Hudson-2 NutMeg DP-to-VGA
DDI_SINGLE_LINK_DVI_I, // Single Link DVI-I
- DDI_CRT, // CRT (VGA)
- DDI_LVDS, // LVDS
+ DDI_DP_W_TYPEC, // DP with USB type C
+ DDI_DP_WO_TYPEC, // DP without USB type C
DDI_EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init
DDI_EDP_TO_LVDS_SW, // eDP-to-LVDS translator which requires AMD SW init
DDI_AUTO_DETECT, // VBIOS auto detect connector type