summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-06-21 16:18:27 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-07-22 08:27:23 +0000
commit27387c3cf5c681b1f52fd45ebe232df593e5d052 (patch)
tree8b499178a28aa3b8a4b07a6659162ab74ccb6c3c
parent4cdc698707741f4542f8a5757b3c17e66f3dddd9 (diff)
sb/intel/i82801jx: Drop `c3_latency`
The three mainboards using this southbridge do not define it. Note that the default value of zero might be wrong, so add a FIXME comment. Change-Id: Id16bb12a4628daf311bddf7e4701fc480d6b18e5 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/42656 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r--src/southbridge/intel/i82801jx/chip.h1
-rw-r--r--src/southbridge/intel/i82801jx/fadt.c2
2 files changed, 1 insertions, 2 deletions
diff --git a/src/southbridge/intel/i82801jx/chip.h b/src/southbridge/intel/i82801jx/chip.h
index 028d5c8bf0..ba8d007fb7 100644
--- a/src/southbridge/intel/i82801jx/chip.h
+++ b/src/southbridge/intel/i82801jx/chip.h
@@ -48,7 +48,6 @@ struct southbridge_intel_i82801jx_config {
int c4onc3_enable:1;
int c5_enable : 1;
int c6_enable : 1;
- int c3_latency;
int docking_supported:1;
int throttle_duty : 3;
diff --git a/src/southbridge/intel/i82801jx/fadt.c b/src/southbridge/intel/i82801jx/fadt.c
index f2b408b119..d99872d396 100644
--- a/src/southbridge/intel/i82801jx/fadt.c
+++ b/src/southbridge/intel/i82801jx/fadt.c
@@ -36,7 +36,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
fadt->pm_tmr_len = 4;
fadt->gpe0_blk_len = 16;
fadt->p_lvl2_lat = 1;
- fadt->p_lvl3_lat = chip->c3_latency;
+ fadt->p_lvl3_lat = 0; /* FIXME: Is this correct? */
fadt->duty_offset = 1;
fadt->duty_width = 0;
fadt->day_alrm = 0xd;