summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Zieba <robertzieba@google.com>2022-07-11 11:01:33 -0600
committerMartin L Roth <gaumless@tutanota.com>2022-07-20 22:32:43 +0000
commit247d034a7a309914ce8c9d508d6e198b394d5fed (patch)
tree6794d640b2d6557af16350bed9da3a3abc558844
parentd1cc04b5eb5e418edce072e4950b4d9247de93a3 (diff)
mainboard/google/skyrim/baseboard: Enable Wake-On-LAN functionality
The generic wifi driver currently contains a lot of intel-specific functionality that interferes with enabling wake-on-lan. This commit changes the device tree to use the generic PCIe driver which better supports this functionality. BUG=b:237682766 TEST=Booted on skyrim device and verified that wake on LAN works Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: I5d15d33fd0a152eb3bf2bfe78e802483a701e750 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65800 Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/skyrim/Kconfig2
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/devicetree.cb6
2 files changed, 5 insertions, 3 deletions
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index 4666d817ee..379fd43386 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -23,7 +23,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_I2C_NAU8825
select DRIVERS_USB_HUB
select DRIVERS_UART_ACPI
- select DRIVERS_WIFI_GENERIC
+ select DRIVERS_PCIE_GENERIC
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_ESPI
select EC_GOOGLE_CHROMEEC_SKUID
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
index 5548d8fbe6..71f1a5f510 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
@@ -64,8 +64,10 @@ chip soc/amd/sabrina
end
end
device ref gpp_bridge_0 on # WLAN
- chip drivers/wifi/generic
- register "wake" = "GEVENT_8"
+ chip drivers/pcie/generic
+ register "wake_gpe" = "GEVENT_8"
+ register "wake_deepest" = "ACPI_S0"
+ register "name" = ""WLAN""
device pci 00.0 on end
end
end