summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2013-05-07 13:19:56 -0700
committerAlexandru Gagniuc <mr.nuke.me@gmail.com>2013-11-24 16:10:46 +0100
commit1c097107099201e60be5745b839268752878dc34 (patch)
tree8e0c2070b2f0134a9a4f7ebb203b7916af5f221b
parent58181124f656af4362395765933ab7747aaba8b4 (diff)
haswell: Remove limit on package C-state
With the XHCI controller enabled we no longer hang the system when dropping into a package C-state so remove the code that was disabling it. Change-Id: Icd60488fd2506dac04fb6ec96a77bec265b10d8c Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/50355 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/4163 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
-rw-r--r--src/cpu/intel/haswell/haswell_init.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c
index 071135c3f2..b2e6eaf324 100644
--- a/src/cpu/intel/haswell/haswell_init.c
+++ b/src/cpu/intel/haswell/haswell_init.c
@@ -426,10 +426,7 @@ static void configure_c_states(void)
msr.lo |= (1 << 26); // C1 Auto Demotion Enable
msr.lo |= (1 << 25); // C3 Auto Demotion Enable
msr.lo &= ~(1 << 10); // Disable IO MWAIT redirection
- msr.lo &= ~(0xf); // Clear deepest package c-state
- /* FIXME: The deepest package c-state is set to C0/C1 to work around
- * platform instability when package C3 or deeper c-states are used. */
- msr.lo |= 0; // Deepeset package c-state is C0/C1.
+ /* The deepest package c-state defaults to factory-configured value. */
wrmsr(MSR_PMG_CST_CONFIG_CONTROL, msr);
msr = rdmsr(MSR_PMG_IO_CAPTURE_BASE);