drivers/i2c/at24rf08c: Disable DRIVER_LENOVO_SERIALS by default

This should be the sane default, as having this option enabled when the
AT24RF08C (Asset Identification EEPROM) is not present on the mainboard
can cause SMBIOS table entries to become "*INVALID*". This can,
for example, result in strange hostnames when an OS installer uses
SMBIOS information to automatically generate one. On the other hand,
the coreboot generated SMBIOS tables will at least always contain basic
information. Therefore, this driver should be treated as an enhancement
rather than a default.

Currently, the following mainboards have this option disabled:

  - ThinkCentre M710s
  - ThinkCentre M700 / M900 Tiny
  - Haswell ThinkPads
    - ThinkPad T440p
    - ThinkPad W541

Therefore, we can remove this option entirely on these mainboards. Note
that there may be other mainboards which do not have this chip present
but still have the option enabled. However, this requires a more
detailed investigation which would be out of scope of this change.

TESTS=Timeless builds on lenovo mainboards produce the same binary.

config INCLUDE_CONFIG_FILE
	default n

Was temporarily added to `mb/lenovo/Kconfig` during these tests, as
while the configuration does not change, the order of entries do.
Therefore, technically producing a different binary when included.

Change-Id: I5bb101bd6696c39718ee779426d0ec3e721e1b51
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84544
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

23 files changed, 20 insertions, 12 deletions

diff --git a/src/drivers/i2c/at24rf08c/Kconfig b/src/drivers/i2c/at24rf08c/Kconfig
index 5834cff2f6..a930a46123 100644
--- a/src/drivers/i2c/at24rf08c/Kconfig
+++ b/src/drivers/i2c/at24rf08c/Kconfig
@@ -2,5 +2,4 @@
 
 config DRIVER_LENOVO_SERIALS
 	bool
-	default y if VENDOR_LENOVO
 	select SMBIOS_PROVIDED_BY_MOBO
diff --git a/src/mainboard/lenovo/haswell/Kconfig b/src/mainboard/lenovo/haswell/Kconfig
index a5c8054bb8..b2fc97d051 100644
--- a/src/mainboard/lenovo/haswell/Kconfig
+++ b/src/mainboard/lenovo/haswell/Kconfig
@@ -72,10 +72,6 @@ config USBDEBUG_HCD_INDEX
 	int
 	default 2
 
-config DRIVER_LENOVO_SERIALS
-	bool
-	default n
-
 config PS2K_EISAID
 	default "LEN0071"
 
diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig
index 597fa48890..9912098b95 100644
--- a/src/mainboard/lenovo/l520/Kconfig
+++ b/src/mainboard/lenovo/l520/Kconfig
@@ -5,6 +5,7 @@ if BOARD_LENOVO_L520
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_4096
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
 	select HAVE_ACPI_RESUME
diff --git a/src/mainboard/lenovo/m900_tiny/Kconfig b/src/mainboard/lenovo/m900_tiny/Kconfig
index ffcf05879c..8ad36e0014 100644
--- a/src/mainboard/lenovo/m900_tiny/Kconfig
+++ b/src/mainboard/lenovo/m900_tiny/Kconfig
@@ -2,6 +2,7 @@
 
 if BOARD_LENOVO_THINKCENTRE_M900_TINY
 
+# TODO: fix and enable DRIVER_LENOVO_SERIALS
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384
@@ -37,8 +38,4 @@ config PRERAM_CBMEM_CONSOLE_SIZE
 config DIMM_SPD_SIZE
 	default 512 #DDR4
 
-# TODO: fix and enable
-config DRIVER_LENOVO_SERIALS
-	default n
-
 endif
diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig
index 94b8c848d2..49c8820613 100644
--- a/src/mainboard/lenovo/s230u/Kconfig
+++ b/src/mainboard/lenovo/s230u/Kconfig
@@ -5,6 +5,7 @@ if BOARD_LENOVO_S230U
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_12288
+	select DRIVER_LENOVO_SERIALS
 	select EC_ACPI
 	select EC_COMPAL_ENE932
 	select GFX_GMA_PANEL_1_ON_LVDS
diff --git a/src/mainboard/lenovo/t400/Kconfig b/src/mainboard/lenovo/t400/Kconfig
index 1951d55a39..5afcde8b81 100644
--- a/src/mainboard/lenovo/t400/Kconfig
+++ b/src/mainboard/lenovo/t400/Kconfig
@@ -23,6 +23,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select SUPERIO_NSC_PC87382
 	select SUPERIO_NSC_PC87384
 	select DRIVERS_LENOVO_HYBRID_GRAPHICS
+	select DRIVER_LENOVO_SERIALS
 	select MAINBOARD_HAS_LIBGFXINIT
 	select MAINBOARD_USES_IFD_GBE_REGION if !BOARD_LENOVO_R500
 	select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig
index 2ee85302d0..9c78cb1741 100644
--- a/src/mainboard/lenovo/t410/Kconfig
+++ b/src/mainboard/lenovo/t410/Kconfig
@@ -25,6 +25,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select H8_HAS_BAT_THRESHOLDS_IMPL
 	select MAINBOARD_HAS_LIBGFXINIT
 	select DRIVERS_RICOH_RCE822
+	select DRIVER_LENOVO_SERIALS
 
 config VBOOT
 	select VBOOT_VBNV_FLASH
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig
index 5e9dc6947d..e2137a3379 100644
--- a/src/mainboard/lenovo/t420/Kconfig
+++ b/src/mainboard/lenovo/t420/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select HAVE_ACPI_RESUME
 	select INTEL_INT15
 	select DRIVERS_RICOH_RCE822
+	select DRIVER_LENOVO_SERIALS
 	select MEMORY_MAPPED_TPM
 	select MAINBOARD_HAS_TPM1
 	select MAINBOARD_HAS_LIBGFXINIT
diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig
index f71722d4aa..5ed1fdefe9 100644
--- a/src/mainboard/lenovo/t420s/Kconfig
+++ b/src/mainboard/lenovo/t420s/Kconfig
@@ -6,6 +6,7 @@ config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192
 	select DRIVERS_LENOVO_HYBRID_GRAPHICS
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
 	select GFX_GMA_PANEL_1_ON_LVDS
diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig
index 3d2812c371..e136871503 100644
--- a/src/mainboard/lenovo/t430/Kconfig
+++ b/src/mainboard/lenovo/t430/Kconfig
@@ -6,6 +6,7 @@ config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_12288
 	select DRIVERS_LENOVO_HYBRID_GRAPHICS
+	select DRIVER_LENOVO_SERIALS
 	select DRIVERS_RICOH_RCE822
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig
index 45a06f5fc3..9a7a91b512 100644
--- a/src/mainboard/lenovo/t430s/Kconfig
+++ b/src/mainboard/lenovo/t430s/Kconfig
@@ -26,6 +26,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select INTEL_GMA_HAVE_VBT
 	select MAINBOARD_USES_IFD_GBE_REGION
 	select DRIVERS_RICOH_RCE822 if BOARD_LENOVO_T431S
+	select DRIVER_LENOVO_SERIALS
 	select HAVE_SPD_IN_CBFS if BOARD_LENOVO_T431S
 
 	# Workaround for EC/KBC IRQ1.
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig
index 54447c71e0..663113b98f 100644
--- a/src/mainboard/lenovo/t520/Kconfig
+++ b/src/mainboard/lenovo/t520/Kconfig
@@ -23,6 +23,7 @@ config BOARD_LENOVO_BASEBOARD_T520
 	select DRIVERS_LENOVO_HYBRID_GRAPHICS
 	select INTEL_GMA_HAVE_VBT if BOARD_LENOVO_T520
 	select MAINBOARD_USES_IFD_GBE_REGION
+	select DRIVER_LENOVO_SERIALS
 
 	# Workaround for EC/KBC IRQ1.
 	select SERIRQ_CONTINUOUS_MODE
diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index f237f90176..a797656d71 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -4,6 +4,7 @@ config BOARD_LENOVO_BASEBOARD_T530
 	def_bool n
 	select BOARD_ROMSIZE_KB_12288
 	select DRIVERS_LENOVO_HYBRID_GRAPHICS
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
 	select GFX_GMA_PANEL_1_ON_LVDS
diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig
index a7abbcdbff..ec3a6e01bb 100644
--- a/src/mainboard/lenovo/t60/Kconfig
+++ b/src/mainboard/lenovo/t60/Kconfig
@@ -15,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select EC_LENOVO_PMH7
 	select EC_LENOVO_H8
 	select DRIVERS_I2C_CK505
+	select DRIVER_LENOVO_SERIALS
 	select HAVE_OPTION_TABLE
 	select INTEL_INT15
 	select HAVE_MP_TABLE
diff --git a/src/mainboard/lenovo/thinkcentre_a58/Kconfig b/src/mainboard/lenovo/thinkcentre_a58/Kconfig
index 353d323a79..e24d502092 100644
--- a/src/mainboard/lenovo/thinkcentre_a58/Kconfig
+++ b/src/mainboard/lenovo/thinkcentre_a58/Kconfig
@@ -14,6 +14,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select HAVE_CMOS_DEFAULT
 	select HAVE_ACPI_RESUME
 	select DRIVERS_I2C_CK505
+	select DRIVER_LENOVO_SERIALS
 	select INTEL_GMA_HAVE_VBT
 	select MAINBOARD_HAS_LIBGFXINIT
 
diff --git a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
index c9bcd75ff3..c01aaece08 100644
--- a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
+++ b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
@@ -23,7 +23,4 @@ config MAINBOARD_DIR
 config MAINBOARD_PART_NUMBER
 	default "ThinkCentre M710s"
 
-config DRIVER_LENOVO_SERIALS
-	default n
-
 endif # BOARD_LENOVO_THINKCENTRE_M710S
diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig
index ab421f26ab..67d7980613 100644
--- a/src/mainboard/lenovo/x131e/Kconfig
+++ b/src/mainboard/lenovo/x131e/Kconfig
@@ -5,6 +5,7 @@ if BOARD_LENOVO_X131E
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_12288
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select GFX_GMA_PANEL_1_ON_LVDS
 	select HAVE_ACPI_RESUME
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
index 0604202ee1..4e4c58b246 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
+++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
@@ -6,6 +6,7 @@ config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_12288
 	select DRIVERS_RICOH_RCE822
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
 	select GFX_GMA_PANEL_1_ON_LVDS
diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig
index 5f1298b463..29e2f6ca91 100644
--- a/src/mainboard/lenovo/x200/Kconfig
+++ b/src/mainboard/lenovo/x200/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select INTEL_INT15
 	select SUPERIO_NSC_PC87382
 	select DRIVERS_LENOVO_WACOM
+	select DRIVER_LENOVO_SERIALS
 	select MAINBOARD_HAS_LIBGFXINIT
 	select MAINBOARD_USES_IFD_GBE_REGION
 
diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig
index dcf13ecc19..8517232d20 100644
--- a/src/mainboard/lenovo/x201/Kconfig
+++ b/src/mainboard/lenovo/x201/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select MAINBOARD_HAS_LIBGFXINIT
 	select SUPERIO_NSC_PC87382
 	select DRIVERS_LENOVO_WACOM
+	select DRIVER_LENOVO_SERIALS
 	select MEMORY_MAPPED_TPM
 	select MAINBOARD_HAS_TPM1
 	select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig
index 453601c3e3..e6a2e66209 100644
--- a/src/mainboard/lenovo/x220/Kconfig
+++ b/src/mainboard/lenovo/x220/Kconfig
@@ -6,6 +6,7 @@ config BOARD_SPECIFIC_OPTIONS
 	def_bool y
 	select BOARD_ROMSIZE_KB_8192
 	select DRIVERS_RICOH_RCE822
+	select DRIVER_LENOVO_SERIALS
 	select EC_LENOVO_H8
 	select EC_LENOVO_PMH7
 	select GFX_GMA_PANEL_1_ON_LVDS
diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index d14730a1c5..1d04af9bff 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select HAVE_ACPI_RESUME
 	select INTEL_INT15
 	select DRIVERS_RICOH_RCE822
+	select DRIVER_LENOVO_SERIALS
 	select MEMORY_MAPPED_TPM
 	select MAINBOARD_HAS_TPM1 if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T || BOARD_LENOVO_X230_EDP
 	select MAINBOARD_HAS_LIBGFXINIT
diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig
index eaf3700030..0f12a9272e 100644
--- a/src/mainboard/lenovo/x60/Kconfig
+++ b/src/mainboard/lenovo/x60/Kconfig
@@ -15,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select EC_LENOVO_PMH7
 	select EC_LENOVO_H8
 	select DRIVERS_I2C_CK505
+	select DRIVER_LENOVO_SERIALS
 	select HAVE_OPTION_TABLE
 	select INTEL_INT15
 	select HAVE_CMOS_DEFAULT