summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichał Żygowski <michal.zygowski@3mdeb.com>2018-06-26 14:52:51 +0200
committerPatrick Georgi <pgeorgi@google.com>2018-07-03 11:07:13 +0000
commit0be6cee817d69fa32230405bc1eb70b6505ab88a (patch)
tree651fda32208e65daec94cde95425f9cc4987f603
parentbe6958ede43a62f7bd46fc68fa68f92a32104d05 (diff)
mb/pcengines/apu1: use generic SPD
Clean up leftovers of old SPD generation and utilize common procedure to produce SPD binary. Change-Id: I4e48817c03b4372887bc0ea14209736ae2b4e48f Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Reviewed-on: https://review.coreboot.org/27301 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--src/mainboard/pcengines/apu1/Kconfig1
-rw-r--r--src/mainboard/pcengines/apu1/Makefile.inc19
-rw-r--r--src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex (renamed from src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex)0
-rw-r--r--src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex (renamed from src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex)0
4 files changed, 3 insertions, 17 deletions
diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig
index 8361d8d1d8..6c98d01147 100644
--- a/src/mainboard/pcengines/apu1/Kconfig
+++ b/src/mainboard/pcengines/apu1/Kconfig
@@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select BOARD_ROMSIZE_KB_2048
+ select GENERIC_SPD_BIN
config MAINBOARD_DIR
string
diff --git a/src/mainboard/pcengines/apu1/Makefile.inc b/src/mainboard/pcengines/apu1/Makefile.inc
index 324e4aa365..543ac97723 100644
--- a/src/mainboard/pcengines/apu1/Makefile.inc
+++ b/src/mainboard/pcengines/apu1/Makefile.inc
@@ -31,22 +31,7 @@ ramstage-y += BiosCallOuts.c
ramstage-y += OemCustomize.c
ramstage-y += gpio_ftns.c
-## DIMM SPD for on-board memory
-SPD_BIN = $(obj)/spd.bin
# Order of names in SPD_SOURCES is important!
-SPD_SOURCES = HYNIX-H5TQ2G83CFR HYNIX-H5TQ4G83MFR
-
-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex)
-
-# Include spd ROM data
-$(SPD_BIN): $(SPD_DEPS)
- for f in $+; \
- do for c in $$(cat $$f | grep -v ^#); \
- do printf $$(printf '\%o' 0x$$c); \
- done; \
- done > $@
-
-cbfs-files-y += spd.bin
-spd.bin-file := $(SPD_BIN)
-spd.bin-type := spd
+SPD_SOURCES = HYNIX-H5TQ2G83CFR
+SPD_SOURCES += HYNIX-H5TQ4G83MFR
diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
index c9138c05b3..c9138c05b3 100644
--- a/src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex
+++ b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex
index f091d6b294..f091d6b294 100644
--- a/src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex
+++ b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex