diff options
| author | Martin Roth <martinroth@google.com> | 2016-11-09 14:27:00 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-12-12 18:07:51 +0100 |
| commit | 08705f1e904288607df87eb7627178613066bd99 (patch) | |
| tree | 9623c79fd393d600127c42fae79c2b4e5b9c52c8 | |
| parent | 1c9c4b8db8ee791d124638b7381e85bf4298f0f5 (diff) | |
lint/kconfig_lint: Make sure all symbols have a type defined
Show an error if a symbol does not have a defined type.
This caused a problem of an undefined symbol in check_defaults, so
we just skip those symbols there as we can't verify the default pattern
without knowing the type.
Change-Id: I28711a77962e16f6fc89789400363edd0fdd0931
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/17345
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@googlemail.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rwxr-xr-x | util/lint/kconfig_lint | 29 | ||||
| -rw-r--r-- | util/lint/kconfig_lint_README | 1 |
2 files changed, 30 insertions, 0 deletions
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index ae10c03274..bbf3e38142 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -85,6 +85,7 @@ sub Main { load_config($config_file) if ($config_file); + check_type(); check_defaults(); check_referenced_symbols(); @@ -273,6 +274,31 @@ sub check_for_def { } #------------------------------------------------------------------------------- +# check_type - Make sure that all symbols have a type defined. +# +# Conflicting types are found when parsing the Kconfig tree. +#------------------------------------------------------------------------------- +sub check_type { + + # loop through each defined symbol + foreach my $sym ( sort ( keys %symbols ) ) { + + # Make sure there's a type set for the symbol + if (!defined $symbols{$sym}{type}) { + + #loop through each instance of that symbol + for ( my $sym_num = 0 ; $sym_num <= $symbols{$sym}{count} ; $sym_num++ ) { + + my $filename = $symbols{$sym}{$sym_num}{file}; + my $line_no = $symbols{$sym}{$sym_num}{line_no}; + + show_error("No type defined for symbol $sym defined at $filename:$line_no."); + } + } + } +} + +#------------------------------------------------------------------------------- # check_is_enabled - The IS_ENABLED() macro is only valid for symbols of type # bool. It would probably work on type hex or int if the value was 0 or 1, but # this seems like a bad plan. Using it on strings is dead out. @@ -333,6 +359,9 @@ sub check_defaults { my $filename = $symbols{$sym}{$sym_num}{file}; my $line_no = $symbols{$sym}{$sym_num}{default}{$def_num}{default_line_no}; + # Make sure there's a type set for the symbol + next if (!defined $symbols{$sym}{type}); + # skip good defaults if (! ((($symbols{$sym}{type} eq "hex") && ($symbols{$sym}{$sym_num}{default}{$def_num}{default} =~ /^0x/)) || (($symbols{$sym}{type} eq "int") && ($symbols{$sym}{$sym_num}{default}{$def_num}{default} =~ /^[-0-9]+$/)) || diff --git a/util/lint/kconfig_lint_README b/util/lint/kconfig_lint_README index 5a5eacdb88..c36320edb2 100644 --- a/util/lint/kconfig_lint_README +++ b/util/lint/kconfig_lint_README @@ -89,6 +89,7 @@ Errors in Kconfig that are also caught by Kconfig itself: int in another location. - Type keywords (bool, int, hex, string) used outside of a config block. - Using a 'prompt' keyword not inside a config or choice block. +- Symbols with no defined type. Errors in coreboot source files: - The IS_ENABLED macro is only valid for bool symbols. |