diff options
| author | Nico Huber <nico.huber@secunet.com> | 2017-04-05 17:33:46 +0200 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2017-06-06 17:22:12 +0200 |
| commit | 0660c6c1ffb8ff1de04d62432a22b2f0a625fca2 (patch) | |
| tree | 319d5a8a0f9249ebadbb56364d7006b13fa69ce5 | |
| parent | ed9c9ce26841a958dac3517646f655e2a1887a5b (diff) | |
inteltool: Fix clean-up and close related TODO
We have to call pci_free_dev() for each device we allocated with
pci_get_dev(). Since that's not the case for `sb`, we can close
this TODO.
Change-Id: I1ef80c837263a205467f835156dcb8fa667d3a8f
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/19587
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | util/inteltool/inteltool.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index fb24f74793..3f55685993 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -568,8 +568,12 @@ int main(int argc, char *argv[]) } /* Clean up */ + if (ahci) + pci_free_dev(ahci); + if (gfx) + pci_free_dev(gfx); pci_free_dev(nb); - // pci_free_dev(sb); // TODO: glibc detected "double free or corruption" + /* `sb` wasn't allocated by pci_get_dev() */ pci_cleanup(pacc); return 0; |