summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Reinauer <stepan@coresystems.de>2008-12-05 22:38:18 +0000
committerStefan Reinauer <stepan@openbios.org>2008-12-05 22:38:18 +0000
commitce00f1d12c5d992c979e97e926e4e1e521122494 (patch)
treed27e3daed6a406a911bb5e5893f60d5e2e2a22b1
parentf82a07730d033f0c168dd13a7fa5d4d086016376 (diff)
Fixes to AMD MCT code, found by Marco Schmidt <mschmidt@dspace.de>
Signed-off-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Marc Jones <marcj303@gmail.com> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3802 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
-rw-r--r--src/northbridge/amd/amdmct/mct/mct_d.c2
-rw-r--r--src/northbridge/amd/amdmct/wrappers/mcti_d.c5
2 files changed, 6 insertions, 1 deletions
diff --git a/src/northbridge/amd/amdmct/mct/mct_d.c b/src/northbridge/amd/amdmct/mct/mct_d.c
index 693500e40c..cec708c2b1 100644
--- a/src/northbridge/amd/amdmct/mct/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct/mct_d.c
@@ -3400,6 +3400,8 @@ static void SetODTTriState(struct MCTStatStruc *pMCTstat,
u8 max_dimms;
// FIXME: skip for Ax
+
+ dev = pDCTstat->dev_dct;
/* Tri-state unused ODTs when motherboard termination is available */
max_dimms = (u8) mctGet_NVbits(NV_MAX_DIMMS);
diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
index 93f000de4c..7e111917d1 100644
--- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c
+++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
@@ -197,13 +197,16 @@ u16 mctGet_NVbits(u8 index)
case NV_CS_SpareCTL:
val = 0; /* Disabled */
//val = 1; /* Enabled */
+ break;
case NV_SyncOnUnEccEn:
val = 0; /* Disabled */
//val = 1; /* Enabled */
+ break;
case NV_Unganged:
/* channel interleave is better performance than ganged mode at this time */
val = 1; /* Enabled */
//val = 0; /* Disabled */
+ break;
case NV_ChannelIntlv:
val = 5; /* Not currently checked in mctchi_d.c */
/* Bit 0 = 0 - Disable
@@ -213,7 +216,7 @@ u16 mctGet_NVbits(u8 index)
* 10b - Hash*, XOR of address bits [20:16, 6]
* 11b - Hash*, XOR of address bits [20:16, 9]
*/
-
+ break;
}
return val;