summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-01-01 17:42:45 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2020-01-09 18:46:05 +0000
commitbbcf1a0878e52570f5c8c8ffec8e166f591b3df9 (patch)
tree97436beccbee92cdbd157cbd949881f11f5d7d82
parentd1c69c65ce50fd1499f9db104ce634fc19af0251 (diff)
soc/intel/common: Drop old forked version of SMBUS support
Switch to use the more recent version in sb/intel/common. Change-Id: Idbff410991db9592a58b9cc0ae7ee8c45d750b13 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38149 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/soc/intel/common/block/smbus/smbus.c1
-rw-r--r--src/soc/intel/common/block/smbus/smbuslib.c161
-rw-r--r--src/soc/intel/common/block/smbus/smbuslib.h6
-rw-r--r--src/soc/intel/common/pch/Kconfig1
4 files changed, 4 insertions, 165 deletions
diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c
index f22bacd3b5..95def1116e 100644
--- a/src/soc/intel/common/block/smbus/smbus.c
+++ b/src/soc/intel/common/block/smbus/smbus.c
@@ -20,6 +20,7 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <soc/smbus.h>
+#include <southbridge/intel/common/smbus.h>
#include "smbuslib.h"
static int lsmbus_read_byte(struct device *dev, u8 address)
diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c
index 0004ba7709..126adee06b 100644
--- a/src/soc/intel/common/block/smbus/smbuslib.c
+++ b/src/soc/intel/common/block/smbus/smbuslib.c
@@ -13,171 +13,12 @@
* GNU General Public License for more details.
*/
-#include <arch/io.h>
#include <console/console.h>
-#include <device/smbus_def.h>
#include <spd_bin.h>
+#include <southbridge/intel/common/smbus.h>
#include <string.h>
-#include <timer.h>
#include "smbuslib.h"
-static int smbus_wait_till_ready(u16 smbus_base)
-{
- struct stopwatch sw;
- unsigned char byte;
-
- stopwatch_init_msecs_expire(&sw, SMBUS_TIMEOUT);
- do {
- byte = inb(smbus_base + SMBHSTSTAT);
- if (!(byte & 1))
- return 0;
- } while (!stopwatch_expired(&sw));
- return -1;
-}
-
-static int smbus_wait_till_done(u16 smbus_base)
-{
- struct stopwatch sw;
- unsigned char byte;
-
- stopwatch_init_msecs_expire(&sw, SMBUS_TIMEOUT);
- do {
- byte = inb(smbus_base + SMBHSTSTAT);
- if (!((byte & 1) || (byte & ~((1 << 6) | (1 << 0))) == 0))
- return 0;
- } while (!stopwatch_expired(&sw));
- return -1;
-}
-
-int do_smbus_read_byte(unsigned int smbus_base, u8 device, unsigned int address)
-{
- unsigned char global_status_register;
- unsigned char byte;
-
- if (smbus_wait_till_ready(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_READY_TIMEOUT;
-
- /* Setup transaction */
- /* Disable interrupts */
- outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);
- /* Set the device I'm talking to */
- outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);
- /* Set the command/address... */
- outb(address & 0xff, smbus_base + SMBHSTCMD);
- /* Set up for a byte data read */
- outb((inb(smbus_base + SMBHSTCTL) & 0xe3) | (0x2 << 2),
- (smbus_base + SMBHSTCTL));
- /* Clear any lingering errors, so the transaction will run */
- outb(inb(smbus_base + SMBHSTSTAT), smbus_base + SMBHSTSTAT);
-
- /* Clear the data byte... */
- outb(0, smbus_base + SMBHSTDAT0);
-
- /* Start the command */
- outb((inb(smbus_base + SMBHSTCTL) | 0x40),
- smbus_base + SMBHSTCTL);
-
- /* Poll for transaction completion */
- if (smbus_wait_till_done(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_DONE_TIMEOUT;
-
- global_status_register = inb(smbus_base + SMBHSTSTAT);
-
- /* Ignore the "In Use" status... */
- global_status_register &= ~(3 << 5);
-
- /* Read results of transaction */
- byte = inb(smbus_base + SMBHSTDAT0);
- if (global_status_register != (1 << 1))
- return SMBUS_ERROR;
-
- return byte;
-}
-
-int do_smbus_write_byte(unsigned int smbus_base, u8 device, unsigned int address,
- unsigned int data)
-{
- unsigned char global_status_register;
-
- if (smbus_wait_till_ready(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_READY_TIMEOUT;
-
- /* Setup transaction */
- /* Disable interrupts */
- outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);
- /* Set the device I'm talking to */
- outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);
- /* Set the command/address... */
- outb(address & 0xff, smbus_base + SMBHSTCMD);
- /* Set up for a byte data read */
- outb((inb(smbus_base + SMBHSTCTL) & 0xe3) | (0x2 << 2),
- (smbus_base + SMBHSTCTL));
- /* Clear any lingering errors, so the transaction will run */
- outb(inb(smbus_base + SMBHSTSTAT), smbus_base + SMBHSTSTAT);
-
- /* Clear the data byte... */
- outb(data, smbus_base + SMBHSTDAT0);
-
- /* Start the command */
- outb((inb(smbus_base + SMBHSTCTL) | 0x40),
- smbus_base + SMBHSTCTL);
-
- /* Poll for transaction completion */
- if (smbus_wait_till_done(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_DONE_TIMEOUT;
-
- global_status_register = inb(smbus_base + SMBHSTSTAT);
-
- /* Ignore the "In Use" status... */
- global_status_register &= ~(3 << 5);
-
- /* Read results of transaction */
- if (global_status_register != (1 << 1))
- return SMBUS_ERROR;
-
- return 0;
-}
-
-int do_smbus_read_word(unsigned int smbus_base, u8 device, unsigned int address)
-{
- unsigned char global_status_register;
- unsigned short data;
-
- if (smbus_wait_till_ready(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_READY_TIMEOUT;
-
- /* Set up transaction */
- /* Disable interrupts */
- outb(inb(smbus_base + SMBHSTCTL) & ~1, smbus_base + SMBHSTCTL);
- /* Set the device I'm talking to */
- outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);
- /* Set the command/address... */
- outb(address & 0xff, smbus_base + SMBHSTCMD);
- /* Set up for a word data read */
- outb((inb(smbus_base + SMBHSTCTL) & 0xe3) | (0x3 << 2),
- (smbus_base + SMBHSTCTL));
- /* Clear any lingering errors, so the transaction will run */
- outb(inb(smbus_base + SMBHSTSTAT), smbus_base + SMBHSTSTAT);
-
- /* Start the command */
- outb((inb(smbus_base + SMBHSTCTL) | 0x40),
- smbus_base + SMBHSTCTL);
-
- /* Poll for transaction completion */
- if (smbus_wait_till_done(smbus_base) < 0)
- return SMBUS_WAIT_UNTIL_DONE_TIMEOUT;
-
- global_status_register = inb(smbus_base + SMBHSTSTAT);
- /* Ignore the "In Use" status... */
- if ((global_status_register & ~(3 << 5)) != (1 << 1))
- return SMBUS_ERROR;
-
- /* Read results of transaction */
- data = inw(smbus_base + SMBHSTDAT0);
-
- return data;
-}
-
static void update_spd_len(struct spd_block *blk)
{
u8 i, j = 0;
diff --git a/src/soc/intel/common/block/smbus/smbuslib.h b/src/soc/intel/common/block/smbus/smbuslib.h
index 45902a0174..adc2d30d70 100644
--- a/src/soc/intel/common/block/smbus/smbuslib.h
+++ b/src/soc/intel/common/block/smbus/smbuslib.h
@@ -20,6 +20,7 @@
/* SMBus IO Base Address */
#define SMBUS_IO_BASE 0xefa0
+
/* PCI Configuration Space : SMBus */
#define HOSTC 0x40
#define HST_EN (1 << 0)
@@ -32,9 +33,4 @@
#define SMBUS_TIMEOUT 15 /* 15ms */
-int do_smbus_read_byte(unsigned int smbus_base, u8 device, unsigned int address);
-int do_smbus_write_byte(unsigned int smbus_base, u8 device, unsigned int address,
- unsigned int data);
-int do_smbus_read_word(unsigned int smbus_base, u8 device, unsigned int address);
-
#endif /* SOC_INTEL_COMMON_BLOCK_SMBUS__LIB_H */
diff --git a/src/soc/intel/common/pch/Kconfig b/src/soc/intel/common/pch/Kconfig
index 993593da2b..7f662fc38c 100644
--- a/src/soc/intel/common/pch/Kconfig
+++ b/src/soc/intel/common/pch/Kconfig
@@ -44,5 +44,6 @@ config PCH_SPECIFIC_OPTIONS
select SOC_INTEL_COMMON_BLOCK_XDCI
select SOC_INTEL_COMMON_BLOCK_XHCI
select SOC_INTEL_COMMON_PCH_LOCKDOWN
+ select SOUTHBRIDGE_INTEL_COMMON_SMBUS
endif