diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-06-02 15:33:04 +0300 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2020-06-10 01:03:05 +0000 |
| commit | ba17829de4d3c441da4f844c441ea55228533311 (patch) | |
| tree | 9a341caaae2b9fe2ae8ea01e3690823b6b5b8563 | |
| parent | 64e07ebde296007e127896a81a571ebe85acbf95 (diff) | |
sb/intel, ACPI: Do not override FADT preferred_pm_profile
Setting preferred_pm_profile under sb/ overrides the
default determined from SYSTEM_TYPE_xx (or possibly
SMBIOS_ENCLOSURE_TYPE with followup work). This is not desireable.
Boards need to either select a pre-defined SYSTEM_TYPE_xx or provide
board-specific mainboard_fill_fadt() should they need to change this.
As they already select SYSTEM_TYPE_LAPTOP, following boards
will maintain PM_MOBILE:
lenovo/t400
lenovo/x200
roda/rk9
Following will change to PM_DESKTOP:
aopen/dxplplusu
asus/p2b
emulation/qemu-i440fx
emulation/qemu-q35
Change-Id: I2986eb0a8abc94507e9797cc8b64611ae4bd888a
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42186
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
| -rw-r--r-- | src/southbridge/intel/i82371eb/fadt.c | 1 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801dx/fadt.c | 1 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801ix/fadt.c | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index 711b37e384..84745a4a7a 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -18,7 +18,6 @@ */ void acpi_fill_fadt(acpi_fadt_t *fadt) { - fadt->preferred_pm_profile = 0; /* unspecified */ fadt->sci_int = 9; if (permanent_smi_handler()) { diff --git a/src/southbridge/intel/i82801dx/fadt.c b/src/southbridge/intel/i82801dx/fadt.c index b4974195b4..2da2175f01 100644 --- a/src/southbridge/intel/i82801dx/fadt.c +++ b/src/southbridge/intel/i82801dx/fadt.c @@ -21,7 +21,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) { u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe; - fadt->preferred_pm_profile = PM_UNSPECIFIED; fadt->sci_int = 0x9; diff --git a/src/southbridge/intel/i82801ix/fadt.c b/src/southbridge/intel/i82801ix/fadt.c index 75d056f6de..ff30611548 100644 --- a/src/southbridge/intel/i82801ix/fadt.c +++ b/src/southbridge/intel/i82801ix/fadt.c @@ -10,7 +10,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) { u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe; - fadt->preferred_pm_profile = PM_MOBILE; fadt->sci_int = 0x9; if (permanent_smi_handler()) { |