diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-03-15 15:34:45 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2019-03-15 23:04:56 +0000 |
| commit | ada45a3148955a1e8070f27c53542eecd1f81fd9 (patch) | |
| tree | 56d904a77c484dcad49965b62de1f48d68c50978 | |
| parent | 2c8243cf6de4726092b8ff31a73d633ec58baaab (diff) | |
Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line"
This reverts commit b3a8cc54dbaf833c590a56f912209a5632b71f49.
This change was submitted under the incorrect assumption that there was
agreement on a coding style change. There wasn't, so while the issue is
under discussion we should revert to the previous status quo.
Change-Id: I37a5585764346af11a98bdf58c810dd3cf5bfe40
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31915
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | Documentation/coding_style.md | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index e0341939a6..048b8e673e 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -30,11 +30,6 @@ the code move too far to the right, and makes it hard to read on a more than 3 levels of indentation, you're screwed anyway, and should fix your program. -Since most code in a file is indented at least 1 level, we account for -2 levels in addition to the 80 characters on the terminal under the -assumption that editors can scroll to the right, making an 80 characters -screen visible with little loss on the left end. - In short, 8-char indents make things easier to read, and have the added benefit of warning you when you're nesting your functions too deep. Heed that warning. @@ -85,11 +80,11 @@ Get a decent editor and don't leave whitespace at the end of lines. Coding style is all about readability and maintainability using commonly available tools. -The limit on the length of lines is 96 columns (80 columns + 2 tab levels) -and this is a strongly preferred limit. +The limit on the length of lines is 80 columns and this is a strongly +preferred limit. -Statements longer than 96 columns will be broken into sensible chunks, -unless exceeding 96 columns significantly increases readability and does +Statements longer than 80 columns will be broken into sensible chunks, +unless exceeding 80 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break |