diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2018-02-02 15:07:09 +0100 |
|---|---|---|
| committer | Philipp Deppenwiese <zaolin.daisuki@gmail.com> | 2018-04-16 22:27:26 +0000 |
| commit | ad4ddfcfdbf634d2ba4746d92cfd11854f87417a (patch) | |
| tree | c541fb1bfbc990bac5577b4937f9a22ef58062ce | |
| parent | 405d2eabe075444c77df2d9c7949c1125c120ce3 (diff) | |
util/intelmetool: Add additional helpful error messages
Add more verbose error message for common problems on modern
operating systems, like Secure Boot and CONFIG_STRICT_DEVMEM.
Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/25401
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
| -rw-r--r-- | util/intelmetool/intelmetool.c | 3 | ||||
| -rw-r--r-- | util/intelmetool/rcba.c | 6 |
2 files changed, 6 insertions, 3 deletions
diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index ae36fc58fc..5981e9ddbd 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -491,7 +491,8 @@ int main(int argc, char *argv[]) #ifndef __DARWIN__ fd_mem = open("/dev/mem", O_RDWR); if (fd_mem < 0) { - perror("Can not open /dev/mem"); + perror("Can not open /dev/mem. Do you have disabled " + "Secure Boot ?"); exit(1); } diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c index c138e89fd3..ee43e65ce0 100644 --- a/util/intelmetool/rcba.c +++ b/util/intelmetool/rcba.c @@ -68,7 +68,8 @@ int write_rcba32(uint32_t addr, uint32_t val) rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { - printf("Could not map RCBA\n"); + printf("Could not map RCBA\n" + "Do you have cmdline argument 'iomem=relaxed' set ?\n"); return 1; } *(uint32_t *)(rcba + addr) = val; @@ -93,7 +94,8 @@ int read_rcba32(uint32_t addr, uint32_t *val) rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { - printf("Could not map RCBA\n"); + printf("Could not map RCBA\n" + "Do you have cmdline argument 'iomem=relaxed' set ?\n"); return 1; } |