aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>2014-04-18 19:53:51 -0500
committerAlexandru Gagniuc <mr.nuke.me@gmail.com>2014-04-20 21:33:26 +0200
commita9a366171006aad3b928307c2dfb7b3e7793d4ef (patch)
tree33f4057ac112e7a66ef373f5805b39368e682d3d
parent46b0951182c07b7bcd86fd2b66ac162d99eee3f3 (diff)
hp/pavilion_m6_1035dx: Move GEVENT/GPE definitions to common file
These definitions were scattered in a couple of files, and we risk scattering them all over the place. Provide a common file for these definitions. Change-Id: I1fe99e5097cf10a349661f3b2ae2377f5cdd6103 Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Reviewed-on: http://review.coreboot.org/5547 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl6
-rw-r--r--src/mainboard/hp/pavilion_m6_1035dx/ec.h3
-rw-r--r--src/mainboard/hp/pavilion_m6_1035dx/mainboard.h22
3 files changed, 25 insertions, 6 deletions
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
index 188515c165..0293a1274a 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
+++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl
@@ -3,10 +3,8 @@
* Subject to the GNU GPL v2, or (at your option) any later version.
*/
-/*
- * EC bits specific to the mainboard
- */
-#define EC_SCI_GPE 3
+/* Defines EC bits specific to the mainboard, needed by EC ASL */
+#include "mainboard.h"
/* ACPI code for EC functions */
#include <ec/compal/ene932/acpi/ec.asl>
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/ec.h b/src/mainboard/hp/pavilion_m6_1035dx/ec.h
index 7eb4d06d2f..61ecc060f8 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/ec.h
+++ b/src/mainboard/hp/pavilion_m6_1035dx/ec.h
@@ -6,8 +6,7 @@
#ifndef _MAINBOARD_HP_PAVILION_M6_1035DX_EC_H
#define _MAINBOARD_HP_PAVILION_M6_1035DX_EC_H
-#define EC_SMI_GEVENT 23
-#define EC_LID_GEVENT 22
+#include "mainboard.h"
#ifndef __SMM__
void pavilion_m6_1035dx_ec_init(void);
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h
new file mode 100644
index 0000000000..1e69cc9134
--- /dev/null
+++ b/src/mainboard/hp/pavilion_m6_1035dx/mainboard.h
@@ -0,0 +1,22 @@
+/*
+ * "The way things are connected" and a few setup options
+ *
+ * Copyright (C) 2014 Alexandru Gagniuc <mr.nuke.me@gmail.com>
+ * Subject to the GNU GPL v2, or (at your option) any later version.
+ */
+
+#ifndef _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H
+#define _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H
+
+/* What is connected to GEVENT pins */
+#define EC_SCI_GEVENT 3
+#define EC_LID_GEVENT 22
+#define EC_SMI_GEVENT 23
+
+/* Any GEVENT pin can be mapped to any GPE. We try to keep the mapping 1:1, but
+ * we make the distinction between GEVENT pin and SCI.
+ */
+#define EC_SCI_GPE EC_SCI_GEVENT
+
+
+#endif /* _MAINBOARD_HP_PAVILION_M6_1035DX_MAINBOARD_H */