summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2011-10-19 07:23:51 +0300
committerPeter Stuge <peter@stuge.se>2011-10-19 06:49:38 +0200
commit939103c622ea9f9be32675643373a0d99aaba2b2 (patch)
tree36c04d1e8a268ae733cd873c3ef353204c563377
parent76c44aeea997044b85442681094d2315ceb1087b (diff)
IOAPIC: fix bitmask
APIC ID is bits 27..24, not 19..16. Change-Id: Ib53a480bf4328901094ca2c4713e8317321962a1 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/299 Tested-by: build bot (Jenkins) Reviewed-by: Peter Stuge <peter@stuge.se>
-rw-r--r--src/arch/x86/lib/ioapic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c
index 3f64209746..81d964cf94 100644
--- a/src/arch/x86/lib/ioapic.c
+++ b/src/arch/x86/lib/ioapic.c
@@ -79,7 +79,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id)
printk(BIOS_DEBUG, "IOAPIC: ID = 0x%02x\n", ioapic_id);
/* Set IOAPIC ID if it has been specified. */
io_apic_write(ioapic_base, 0x00,
- (io_apic_read(ioapic_base, 0x00) & 0xfff0ffff) |
+ (io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) |
(ioapic_id << 24));
}