summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2020-11-19 14:22:24 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-11-22 22:25:23 +0000
commit8461cec76c7323103cb1f61bae077d9a2b1d252e (patch)
tree8d0da4fe8dc1a4ef2fef9de2b62f0f437dce3563
parentf2baae3735b86ff14a13728a845bd484aa4caf70 (diff)
soc/intel/block/pmclib.c: Properly guard apm_control()
This function is only properly implemented with SMM support. Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47757 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/soc/intel/common/block/pmc/pmclib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c
index 02ca6de496..09af749073 100644
--- a/src/soc/intel/common/block/pmc/pmclib.c
+++ b/src/soc/intel/common/block/pmc/pmclib.c
@@ -713,7 +713,7 @@ void pmc_disable_acpi_timer(void)
void pmc_set_acpi_mode(void)
{
- if (!acpi_is_wakeup_s3()) {
+ if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) {
apm_control(APM_CNT_ACPI_DISABLE);
}
}