summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Reinauer <reinauer@chromium.org>2011-05-11 15:57:07 -0700
committerStefan Reinauer <stefan.reinauer@coreboot.org>2012-03-09 20:32:58 +0100
commit5807555f9a0afb94ad92535dd2933ee4dbd25088 (patch)
tree99f59cec4323f9a819c484d63efffb3f7ab2950d
parentdfab0f69ae9af22a96f68364fb1c0d95798a21c9 (diff)
Don't try to compute I/O for empty sub buses.
I am not sure if the sub bus being 0 is a problem, or if the assumption there has to be at least one non empty link is just wrong. It certainly does not hurt to add a small consistency check in either case. Change-Id: I098446deef96a8baae26a7ca1ddd96e626a06dc5 Signed-off-by: Stefan Reinauer <reinauer@google.com> Reviewed-on: http://review.coreboot.org/693 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/devices/device_util.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/devices/device_util.c b/src/devices/device_util.c
index 9081a36ea2..84fb11505c 100644
--- a/src/devices/device_util.c
+++ b/src/devices/device_util.c
@@ -583,6 +583,8 @@ void search_bus_resources(struct bus *bus, unsigned long type_mask,
if (subbus->link_num
== IOINDEX_SUBTRACTIVE_LINK(res->index))
break;
+ if (!subbus) /* Why can subbus be NULL? */
+ break;
search_bus_resources(subbus, type_mask, type,
search, gp);
continue;