summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2020-02-01 13:04:11 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-02-03 16:44:57 +0000
commit4519277ca2e11ed728754efbe13e1a444c479da3 (patch)
treec8bcf6f104188b16611a1257b2a1c5dcc683785d
parente127a8711f71067979211d53d4b855a353344f50 (diff)
drivers/generic/gfx: Add null pointer error check
acpi_device_scope() will return NULL if it is unable to find the path of the parent device. Return early if this is the case to prevent a null pointer dereference. Change-Id: I3eff1c1e3477c75c7130b52898de7d59692ba412 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 1409672 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38669 Reviewed-by: David Hendricks <david.hendricks@gmail.com> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/drivers/generic/gfx/gfx.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c
index b2bda4a43c..0386e9b2ef 100644
--- a/src/drivers/generic/gfx/gfx.c
+++ b/src/drivers/generic/gfx/gfx.c
@@ -69,6 +69,9 @@ static void gfx_fill_ssdt_generator(struct device *dev)
const char *scope = acpi_device_scope(dev);
+ if (!scope)
+ return;
+
acpigen_write_scope(scope);
/* Method (_DOD, 0) */