summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-04-19 13:42:27 -0500
committerAaron Durbin <adurbin@chromium.org>2016-04-21 16:07:39 +0200
commit0eb1f1cba9080f2ab11d5492842f4d3c3c09af17 (patch)
tree28ae3ad173f22201b392b929b4d404b1eb29dab6
parentf7dca0a27599ae05e4d7dad9fde8dd34f6d176fd (diff)
arch/riscv/tables: remove confusion over write_tables()
Apparently the memo was missed about the write_tables() signature. Fix the confusion. Change-Id: I8ef367345dd54584c57e9d5cd8cc3d81ce109fef Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/14421 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--src/arch/riscv/tables.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/arch/riscv/tables.c b/src/arch/riscv/tables.c
index ca0dd306af..f2d0c86db9 100644
--- a/src/arch/riscv/tables.c
+++ b/src/arch/riscv/tables.c
@@ -25,8 +25,7 @@
#define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
-// WTF. this does not agre with the prototype!
-static struct lb_memory *wtf_write_tables(void)
+void write_tables(void)
{
unsigned long table_pointer, new_table_pointer;
@@ -36,7 +35,7 @@ static struct lb_memory *wtf_write_tables(void)
MAX_COREBOOT_TABLE_SIZE);
if (!table_pointer) {
printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
- return NULL;
+ return;
}
new_table_pointer = write_coreboot_table(0UL, 0UL,
@@ -54,13 +53,6 @@ static struct lb_memory *wtf_write_tables(void)
/* Print CBMEM sections */
cbmem_list();
-
-// return get_lb_mem();
- return NULL;
-}
-void write_tables(void)
-{
- wtf_write_tables();
}
void lb_arch_add_records(struct lb_header *header)