diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2018-10-01 13:14:03 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2018-10-04 18:20:16 +0000 |
| commit | a5072af67d85344d6428ab6cfddb34318e1a50ca (patch) | |
| tree | 19a2515401de912fd323d99020c10073fdaab9d8 | |
| parent | 2b59c610d0eda1be7774f32cf417ee7f7c60c582 (diff) | |
util/autoport: Use romstage.c instead of early_southbridge.c
Until now, autoport used to create a dummy "romstage.c", then write
romstage code to "early_southbridge.c". While it works, it makes more
sense to write to "romstage.c" instead, as virtually all mainboards do.
Change-Id: If9f9375f9a659e7e685de5f884163813261fa656
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/28851
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | util/autoport/bd82x6x.go | 3 | ||||
| -rw-r--r-- | util/autoport/main.go | 4 |
2 files changed, 1 insertions, 6 deletions
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 31f7ced273..887a520d9a 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -299,9 +299,8 @@ func (b bd82x6x) Scan(ctx Context, addr PCIDevData) { File: "southbridge/intel/bd82x6x/acpi/pch.asl", }) - sb := Create(ctx, "early_southbridge.c") + sb := Create(ctx, "romstage.c") defer sb.Close() - AddROMStageFile("early_southbridge.c", "") Add_gpl(sb) sb.WriteString(`#include <stdint.h> #include <string.h> diff --git a/util/autoport/main.go b/util/autoport/main.go index 3071559a3d..ed56a55982 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -827,10 +827,6 @@ func main() { fmt.Fprintf(bi, "FIXME: put %s\n", missing) } - rs := Create(ctx, "romstage.c") - defer rs.Close() - rs.WriteString("/* dummy file */\n") - if ROMSizeKB == 0 { KconfigBool["BOARD_ROMSIZE_KB_2048"] = true KconfigComment["BOARD_ROMSIZE_KB_2048"] = "FIXME: correct this" |