summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Huber <nico.huber@secunet.com>2019-10-10 16:44:29 +0200
committerNico Huber <nico.h@gmx.de>2019-10-11 15:28:20 +0000
commit484ad0f1f746b8f0cbd2f051a47bea936d100286 (patch)
treea0ed821dfadc9f7d2992fb2e0864fc2bda52f5be
parent2437fe9dfab8e4056b633a39d51d07aa81ab3c9d (diff)
mb/{razer,purism}: Don't select NO_POST
The NO_POST option covers more than classical port 80 output, hence selecting it seems wrong in any case. The default is still rather user patronizing, but let's keep it. As a side effect, this fixes the ability to override the default for NO_POST which Kconfig rejected while these boards selected it. (Seems like a bug in Kconfig, though.) Change-Id: I896b08812b1aa6ce249d7acc8073ebcc0f72eace Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/35956 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
-rw-r--r--src/mainboard/purism/librem_bdw/Kconfig4
-rw-r--r--src/mainboard/purism/librem_skl/Kconfig5
-rw-r--r--src/mainboard/razer/blade_stealth_kbl/Kconfig4
3 files changed, 10 insertions, 3 deletions
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index 7f7519c73e..9424a7ef3b 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -7,7 +7,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW
select HAVE_ACPI_TABLES
select INTEL_INT15
select SOC_INTEL_BROADWELL
- select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -73,5 +72,8 @@ config VGA_BIOS_ID
default "8086,1616" if BOARD_PURISM_LIBREM13_V1
default "8086,162b" if BOARD_PURISM_LIBREM15_V2
+# This platform has limited means to display POST codes
+config NO_POST
+ default y
endif
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index ecde9e4774..cc0e98a349 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -10,7 +10,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_SKL
select MAINBOARD_USES_FSP2_0
select SPD_READ_BY_WORD
select MAINBOARD_HAS_LPC_TPM
- select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -68,4 +67,8 @@ config CBFS_SIZE
hex
default 0xe00000
+# This platform has limited means to display POST codes
+config NO_POST
+ default y
+
endif
diff --git a/src/mainboard/razer/blade_stealth_kbl/Kconfig b/src/mainboard/razer/blade_stealth_kbl/Kconfig
index 986a4df7bf..7eef3a3522 100644
--- a/src/mainboard/razer/blade_stealth_kbl/Kconfig
+++ b/src/mainboard/razer/blade_stealth_kbl/Kconfig
@@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_ACPI_TABLES
select ADD_FSP_BINARIES
select FSP_USE_REPO
- select NO_POST
# For now no way to choose the correct the available RAM
config BOARD_RAZER_BLADE_STEALTH_KBL_16GB
@@ -52,4 +51,7 @@ config BOARD_SPECIFIC_OPTIONS
int
default 4
+config NO_POST
+ default y
+
endif