diff options
| author | Vladimir Serbinenko <phcoder@gmail.com> | 2014-01-26 23:53:00 +0100 |
|---|---|---|
| committer | Vladimir Serbinenko <phcoder@gmail.com> | 2014-01-27 07:06:02 +0100 |
| commit | e6606518243d9beda31693d40493b5f7a1a3e2e0 (patch) | |
| tree | 627b39f8e0dab63be29f7150424919d15404f121 | |
| parent | a60a3020d9611de3ac9333d0c8791c401a6a70a0 (diff) | |
coreboot_table: don't add CMOS checksum twice.
Checksum is already in cmos_layout.bin. No need to add it twice
Change-Id: I6d12f35fd8ff12eee9a17365bbfab38845c09574
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/4829
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
| -rw-r--r-- | src/lib/coreboot_table.c | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index f433e86b7d..183e10378b 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -30,9 +30,6 @@ #include <cbfs.h> #include <cbmem.h> #include <memrange.h> -#if CONFIG_USE_OPTION_TABLE -#include <option_table.h> -#endif #if CONFIG_CHROMEOS #if CONFIG_GENERATE_ACPI_TABLES #include <arch/acpi.h> @@ -314,26 +311,6 @@ static struct lb_mainboard *lb_mainboard(struct lb_header *header) return mainboard; } -#if CONFIG_USE_OPTION_TABLE -static struct cmos_checksum *lb_cmos_checksum(struct lb_header *header) -{ - struct lb_record *rec; - struct cmos_checksum *cmos_checksum; - rec = lb_new_record(header); - cmos_checksum = (struct cmos_checksum *)rec; - cmos_checksum->tag = LB_TAG_OPTION_CHECKSUM; - - cmos_checksum->size = (sizeof(*cmos_checksum)); - - cmos_checksum->range_start = LB_CKS_RANGE_START * 8; - cmos_checksum->range_end = ( LB_CKS_RANGE_END * 8 ) + 7; - cmos_checksum->location = LB_CKS_LOC * 8; - cmos_checksum->type = CHECKSUM_PCBIOS; - - return cmos_checksum; -} -#endif - static void lb_strings(struct lb_header *header) { static const struct { @@ -510,8 +487,6 @@ unsigned long write_coreboot_table( struct lb_record *rec_dest = lb_new_record(head); /* Copy the option config table, it's already a lb_record... */ memcpy(rec_dest, option_table, option_table->size); - /* Create cmos checksum entry in coreboot table */ - lb_cmos_checksum(head); } else { printk(BIOS_ERR, "cmos_layout.bin could not be found!\n"); } |