summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Singer <felix.singer@secunet.com>2020-08-18 23:12:55 +0200
committerNico Huber <nico.h@gmx.de>2020-08-23 09:56:38 +0000
commit2b9035ed6e51fe835b85dd626e655e1d3901e7ea (patch)
treeb0e337aa12346d02ba98a9a088f515aa4d65c6ac
parentbd409ad69f6f33681bc5cde65cc72eedbd8d2abc (diff)
mb/prodrive/hermes: Add root port numbers to comments
Change-Id: I06bb0493999f1f6954854f872cda46dc38930370 Signed-off-by: Felix Singer <felix.singer@secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44553 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Christian Walter <christian.walter@9elements.com>
-rw-r--r--src/mainboard/prodrive/hermes/devicetree.cb4
-rw-r--r--src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb24
2 files changed, 14 insertions, 14 deletions
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb
index 1ed15a6882..a89ba1b755 100644
--- a/src/mainboard/prodrive/hermes/devicetree.cb
+++ b/src/mainboard/prodrive/hermes/devicetree.cb
@@ -31,11 +31,11 @@ chip soc/intel/cannonlake
device pci 16.1 on end # Management Engine Interface 2
device pci 16.4 on end # Management Engine Interface 3
device pci 17.0 on end # SATA
- device pci 1d.6 on
+ device pci 1d.6 on # PCIe root port 15
device pci 00.0 on # Aspeed PCI Bridge
device pci 00.0 on end # Aspeed 2500 VGA
end
- end # PCIe
+ end
device pci 1f.0 on # LPC Interface
chip drivers/pc80/tpm
device pnp 0c31.0 on end
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
index c3d148d4c1..8098c56981 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
@@ -181,22 +181,22 @@ chip soc/intel/cannonlake
register "devid" = "PCI_DEVICE_ID_INTEL_CNP_H_UART2"
end # UART #2, in ACPI mode
end
- device pci 1b.4 on
+ device pci 1b.4 on # PCIe root port 21 (Slot 1)
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"
- end # PCIe Slot 1
- device pci 1c.0 on
+ end
+ device pci 1c.0 on # PCIe root port 1 (Slot 3)
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT3" "SlotDataBusWidth4X"
- end # PCIe Slot 3
- device pci 1c.4 on end # PHY 3
- device pci 1c.5 on end # PHY 4
- device pci 1c.6 on end # PHY 2
- device pci 1c.7 on end # PHY 1
+ end
+ device pci 1c.4 on end # PCIe root port 5 (PHY 3)
+ device pci 1c.5 on end # PCIe root port 6 (PHY 4)
+ device pci 1c.6 on end # PCIe root port 7 (PHY 2)
+ device pci 1c.7 on end # PCIe root port 8 (PHY 1)
- device pci 1d.0 on
+ device pci 1d.0 on # PCIe root port 9 (M2 M)
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "M2 M" "SlotDataBusWidth4X"
- end # M2 M
- device pci 1d.5 on end # PHY 0
- device pci 1d.6 on end # BMC
+ end
+ device pci 1d.5 on end # PCIe root port 14 (PHY 0)
+ device pci 1d.6 on end # PCIe root port 15 (BMC)
device pci 1e.0 on end # UART #0
device pci 1e.1 on end # UART #1