mb/google/dedede: drop obsolete ISST workaround

Early JSL silicon hang while booting Linux with ISST enabled. The
malfunctioning silicon revisions have been used only for development
purposes and have been phased out. Thus, drop the ISST workaround.

Change-Id: Ic335c0bf03a5b07130f79c24107a1b1b0ae75611
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46459
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>

6 files changed, 0 insertions, 54 deletions

diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c
index 45b25809cd..23b15969c8 100644
--- a/src/mainboard/google/dedede/mainboard.c
+++ b/src/mainboard/google/dedede/mainboard.c
@@ -29,19 +29,6 @@ static void mainboard_update_soc_chip_config(void)
 	}
 }
 
-__weak void variant_isst_override(void)
-{
-	/*
-	 * Implement the override only if the board uses very early/initial revisions of
-	 * Silicon. Otherwise nothing to override.
-	 */
-}
-
-static void mainboard_config_isst(void *unused)
-{
-	variant_isst_override();
-}
-
 static void mainboard_init(void *chip_info)
 {
 	const struct pad_config *base_pads;
@@ -79,6 +66,3 @@ struct chip_operations mainboard_ops = {
 	.init = mainboard_init,
 	.enable_dev = mainboard_enable,
 };
-
-/* Configure ISST before CPU initialization */
-BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, mainboard_config_isst, NULL);
diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
index bd94ef4df3..dc855c63cd 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
@@ -36,7 +36,4 @@ int variant_memory_sku(void);
  */
 bool variant_mem_is_half_populated(void);
 
-/* Variant Intel Speed Shift Technology override */
-void variant_isst_override(void);
-
 #endif /*__BASEBOARD_VARIANTS_H__ */
diff --git a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc
index 93f34f81e0..e835c698be 100644
--- a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc
@@ -3,4 +3,3 @@
 romstage-y += memory.c
 
 ramstage-y += gpio.c
-ramstage-y += variant.c
diff --git a/src/mainboard/google/dedede/variants/waddledee/variant.c b/src/mainboard/google/dedede/variants/waddledee/variant.c
deleted file mode 100644
index ac3cf581d9..0000000000
--- a/src/mainboard/google/dedede/variants/waddledee/variant.c
+++ /dev/null
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <baseboard/variants.h>
-#include <chip.h>
-#include <device/device.h>
-#include <ec/google/chromeec/ec.h>
-
-void variant_isst_override(void)
-{
-	config_t *cfg = config_of_soc();
-	uint32_t board_ver;
-
-	/* Override/Disable ISST in boards where board version is not populated. */
-	if (google_chromeec_get_board_version(&board_ver))
-		cfg->speed_shift_enable = 0;
-}
diff --git a/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc b/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc
index eda535c992..566f5cc767 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc
@@ -1,5 +1,3 @@
 ## SPDX-License-Identifier: GPL-2.0-or-later
 
 romstage-y += memory.c
-
-ramstage-y += variant.c
diff --git a/src/mainboard/google/dedede/variants/waddledoo/variant.c b/src/mainboard/google/dedede/variants/waddledoo/variant.c
deleted file mode 100644
index ac3cf581d9..0000000000
--- a/src/mainboard/google/dedede/variants/waddledoo/variant.c
+++ /dev/null
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <baseboard/variants.h>
-#include <chip.h>
-#include <device/device.h>
-#include <ec/google/chromeec/ec.h>
-
-void variant_isst_override(void)
-{
-	config_t *cfg = config_of_soc();
-	uint32_t board_ver;
-
-	/* Override/Disable ISST in boards where board version is not populated. */
-	if (google_chromeec_get_board_version(&board_ver))
-		cfg->speed_shift_enable = 0;
-}