summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2021-09-06 23:53:58 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-09-08 09:30:55 +0000
commitf88b90f6a9031ddf28c041628534efbfce01a39f (patch)
treeda7bd15ace33afec01cf29c5747fd5fa78e811dc
parent62aa2bb784af331f5323ced9ebad6497ef3b8274 (diff)
mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment
A chip entry in the devicetree is not hooked up without a device beneath it. It seems the intention was to leave these superio drivers unconfigured, so there should be no harm to turn the entries into comments. Change-Id: I6b606f35eba089b74c562084772d95be41cac39c Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/57430 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/mainboard/amd/bilby/devicetree.cb3
-rw-r--r--src/mainboard/amd/mandolin/variants/cereme/devicetree.cb3
-rw-r--r--src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb3
3 files changed, 3 insertions, 6 deletions
diff --git a/src/mainboard/amd/bilby/devicetree.cb b/src/mainboard/amd/bilby/devicetree.cb
index c089d0ddc1..aaf1c3ba85 100644
--- a/src/mainboard/amd/bilby/devicetree.cb
+++ b/src/mainboard/amd/bilby/devicetree.cb
@@ -160,8 +160,7 @@ chip soc/amd/picasso
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain
diff --git a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
index dbb1a14d6d..6342c29f66 100644
--- a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
@@ -149,8 +149,7 @@ chip soc/amd/picasso
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
index 6b5a60b14f..035bb7015b 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
@@ -149,8 +149,7 @@ chip soc/amd/picasso
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain