diff options
| author | Hung-Te Lin <hungte@chromium.org> | 2013-02-07 13:41:56 +0800 |
|---|---|---|
| committer | David Hendricks <dhendrix@chromium.org> | 2013-02-08 02:01:16 +0100 |
| commit | f7fcb2056f2ddf151517366a4caf2b6c52b0d920 (patch) | |
| tree | 6a4546ed2787e2989b6477fd033a1f23a9ea38dd | |
| parent | 31bb2df5086bfde706378b1d80bd53fec69697a2 (diff) | |
console: Always allow setting "EARLY_CONSOLE" configuration.
Early console should always be allowed to be turned on / off (for generating
production and debug versions), and should not be enforced by "select" Kconfig
rule.
A new "DEFAULT_EARLY_CONSOLE" is introduced for devices to select if they
prefer early console output by default.
Verified Kconfig value on qemu/x86 (default y by CACHE_AS_RAM), snow/x86
(default y by EXYNOS5 config), and intel/jarrell (default n).
Change-Id: Ib1cc76d4ec115a302b95e7317224f1a40d1ab035
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/2307
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
| -rw-r--r-- | src/console/Kconfig | 6 | ||||
| -rw-r--r-- | src/cpu/Kconfig | 2 | ||||
| -rw-r--r-- | src/cpu/samsung/Kconfig | 4 |
3 files changed, 7 insertions, 5 deletions
diff --git a/src/console/Kconfig b/src/console/Kconfig index e57d5686e7..7fbed4aafd 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -1,8 +1,12 @@ menu "Console" +config DEFAULT_EARLY_CONSOLE + bool + default n + config EARLY_CONSOLE bool "Enable early (pre-RAM) console output." - default n + default DEFAULT_EARLY_CONSOLE help Use console during early (pre-RAM) boot stages diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig index c2c3816a50..f60ffe7cce 100644 --- a/src/cpu/Kconfig +++ b/src/cpu/Kconfig @@ -16,7 +16,7 @@ source src/cpu/x86/Kconfig config CACHE_AS_RAM bool - select EARLY_CONSOLE + select DEFAULT_EARLY_CONSOLE default !ROMCC config DCACHE_RAM_BASE diff --git a/src/cpu/samsung/Kconfig b/src/cpu/samsung/Kconfig index c905b2af54..c2ee5b49d2 100644 --- a/src/cpu/samsung/Kconfig +++ b/src/cpu/samsung/Kconfig @@ -6,9 +6,7 @@ config CPU_SAMSUNG_EXYNOS5 depends on ARCH_ARMV7 select CPU_SAMSUNG_EXYNOS select HAVE_UART_SPECIAL - # TODO remove EARLY_CONSOLE when we can run ramstage without early UART - # init. - select EARLY_CONSOLE + select DEFAULT_EARLY_CONSOLE bool default n |