diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2016-04-19 13:41:16 -0500 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2016-04-21 16:07:30 +0200 |
| commit | f7dca0a27599ae05e4d7dad9fde8dd34f6d176fd (patch) | |
| tree | 23ea35ad97327f0c3fcb82aa57583d31346c4bb7 | |
| parent | 581c42807d358a66c2a4b3680d465a7069feb2f4 (diff) | |
arch/power8/tables: remove confusion over write_tables()
Apparently the memo was missed about the write_tables()
signature. Fix the confusion.
Change-Id: I63924be47d3507d2d7ed006a553414f4ac60d2f9
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14420
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rw-r--r-- | src/arch/power8/tables.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/src/arch/power8/tables.c b/src/arch/power8/tables.c index d2b2f349d0..b5bc9ab770 100644 --- a/src/arch/power8/tables.c +++ b/src/arch/power8/tables.c @@ -25,8 +25,7 @@ #define MAX_COREBOOT_TABLE_SIZE (8 * 1024) -// WTF. this does not agree with the prototype! -static struct lb_memory *wtf_write_tables(void) +void write_tables(void) { unsigned long table_pointer, new_table_pointer; @@ -36,7 +35,7 @@ static struct lb_memory *wtf_write_tables(void) MAX_COREBOOT_TABLE_SIZE); if (!table_pointer) { printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n"); - return NULL; + return; } new_table_pointer = write_coreboot_table(0UL, 0UL, @@ -55,16 +54,8 @@ static struct lb_memory *wtf_write_tables(void) /* Print CBMEM sections */ cbmem_list(); - -// return get_lb_mem(); - return NULL; } void lb_arch_add_records(struct lb_header *header) { } - -void write_tables(void) -{ - wtf_write_tables(); -} |