summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2022-09-08 10:53:01 -0700
committerSubrata Banik <subratabanik@google.com>2022-09-10 19:00:39 +0000
commitf5afc1a5a2a04c6961b0f86d2b47c801c222f065 (patch)
treea7af762a3173a02a0d8623f8bfcb268cd78677b9
parenta3ad319fbf3105a2763834758f36e6471388fbfd (diff)
soc/intel/meteorlake: Drop redundant `MCHBAR` programming in romstage
This patch drops redundant MCHBAR programming in romstage as bootblock already done with MCHBAR setting up. TEST=Able to boot Google/Rex to ChromeOS and MCHBAR is set to correct value as per iomap.h Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: Ic2c05f47ab22dc7fe087782a1ce9b7b692ea157e Reviewed-on: https://review.coreboot.org/c/coreboot/+/67455 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal@google.com>
-rw-r--r--src/soc/intel/meteorlake/romstage/systemagent.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/soc/intel/meteorlake/romstage/systemagent.c b/src/soc/intel/meteorlake/romstage/systemagent.c
index 6e9b9fa486..ba9b72cd08 100644
--- a/src/soc/intel/meteorlake/romstage/systemagent.c
+++ b/src/soc/intel/meteorlake/romstage/systemagent.c
@@ -8,7 +8,6 @@
void systemagent_early_init(void)
{
static const struct sa_mmio_descriptor soc_fixed_pci_resources[] = {
- { MCHBAR, MCH_BASE_ADDRESS, MCH_BASE_SIZE, "MCHBAR" },
{ DMIBAR, DMI_BASE_ADDRESS, DMI_BASE_SIZE, "DMIBAR" },
{ EPBAR, EP_BASE_ADDRESS, EP_BASE_SIZE, "EPBAR" },
};