diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2020-07-16 14:01:35 -0600 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2020-07-18 16:05:33 +0000 |
| commit | f524188f483b578e346fb73db32846861dfe82e1 (patch) | |
| tree | 0b8c220b20782cf05ca1779ec95145a1c8abbf26 | |
| parent | bec6731c76273f956b8f186cd824939c21b82184 (diff) | |
ec/google/chromeec: Fix oversights in ec_dptf_helpers
GTSH was 2 instead of 20 (so it's 2 degrees K hysteresis), and TSRD was
accidentally defined to take 0 arguments, instead of 1.
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I14d28bacf44ac65043060b8579b3fbcec758c56c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43532
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
| -rw-r--r-- | src/ec/google/chromeec/ec_dptf_helpers.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index 8bb3435630..0f8d4a313b 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -262,7 +262,7 @@ static void write_dppm_methods(const struct device *ec) /* TEVT */ if (CONFIG(EC_SUPPORTS_DPTF_TEVT)) { - acpigen_write_method("TEVT", 0); + acpigen_write_method("TEVT", 1); /* Local0 = ToInteger(Arg0) */ acpigen_write_to_integer(ARG0_OP, LOCAL0_OP); @@ -308,8 +308,11 @@ static void write_thermal_methods(const struct device *ec, enum dptf_participant { dptf_write_scope(participant); - /* GTSH - Amount of hysteresis inherent in temperature reading */ - acpigen_write_name_integer("GTSH", 2); + /* + * GTSH - Amount of hysteresis inherent in temperature reading (2 degrees, in units of + * 1/10th degree K) + */ + acpigen_write_name_integer("GTSH", 20); /* _TMP - read temperature from EC */ acpigen_write_method_serialized("_TMP", 0); |