diff options
| author | Stefan Tauner <stefan.tauner@gmx.at> | 2012-10-13 02:33:35 +0200 |
|---|---|---|
| committer | Peter Stuge <peter@stuge.se> | 2012-10-14 22:22:59 +0200 |
| commit | f450b8619ebcd8dee94d175b2710f07e9884696d (patch) | |
| tree | e3391d14c9c3ccf7cfaa40dccb23c331954212ab | |
| parent | 36156ffa1e86c10456c3ce915705c5a71b8cd708 (diff) | |
inteltool: remove bashism from Makefile
&> is a bashism to redirect both outward streams (stdout and stderr), but
with other shells this introduces a race condition with the rm command
after it, because the compiler execution is done in the background/
in parallel. Found and tested with dash.
Change-Id: I08516494828c9f7af168f954f2df027372657867
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: http://review.coreboot.org/1573
Tested-by: build bot (Jenkins)
Reviewed-by: Bernhard Urban <lewurm@gmail.com>
Reviewed-by: Peter Stuge <peter@stuge.se>
| -rw-r--r-- | util/inteltool/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index d7540059be..af79b1edec 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -59,7 +59,7 @@ pciutils: printf "struct pci_access *pacc;\n"; \ printf "int main(int argc, char **argv)\n"; \ printf "{ pacc = pci_alloc(); return 0; }\n"; ) > .test.c ) - @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \ + @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ printf "found.\n" || ( printf "not found.\n\n"; \ printf "Please install pciutils-devel and zlib-devel.\n"; \ printf "See README for more information.\n\n"; \ |