diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2020-06-18 10:31:33 -0500 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@gmail.com> | 2020-06-20 20:29:01 +0000 |
| commit | eb3ae1a202a31ea12021df30a03e718000b39e5e (patch) | |
| tree | df8bf018ea5d1ab4d9c56e861215ee48497f5386 | |
| parent | e64ef9dee056b139273a3e0ad83c76dd4c3254f6 (diff) | |
mb/google/jecht: Correct hda_verb mic pin configs
Commit 0148fcb4 [Combine Broadwell Chromeboxes using variant board scheme]
incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19,
so set them back to the correct values, which match the original
Chromium sources (where the NID identifiers in the pin config comments
were reversed, which was the source of the confusion originally.
Test: build/boot guado variant, verify mic attached to 3.5mm jack functional
Change-Id: I65b813c8f801303682762ce5a7446e07af117b9f
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42518
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/jecht/hda_verb.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/mainboard/google/jecht/hda_verb.c b/src/mainboard/google/jecht/hda_verb.c index 170d0a6b56..3609de9274 100644 --- a/src/mainboard/google/jecht/hda_verb.c +++ b/src/mainboard/google/jecht/hda_verb.c @@ -27,15 +27,15 @@ const u32 cim_verb_data[] = { /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0), - /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC2 PORTF */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1A, 0x411111f0), |