summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYu-Ping Wu <yupingso@google.com>2019-10-23 16:51:26 +0800
committerPatrick Georgi <pgeorgi@google.com>2019-10-24 15:49:10 +0000
commitea4bda55d62d90e008a5aa455f24adcd7759b37a (patch)
treec79d6b182d378d273fded70da5f1485c270b82bc
parent241f0a559347a9ee5325b94c0a021dd404da4030 (diff)
soc/mediatek/mt8183: Add udelay after setting voltages
The SOC DRAM team suggested to delay at least 1us after setting new voltage in PMIC wrapper so the new value can be effective. BRANCH=kukui BUG=b:142358843 TEST=emerge-kukui coreboot Change-Id: I19d236769c3c0c87513ea4a0a3f64b83e3a844c2 Signed-off-by: Yu-Ping Wu <yupingso@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36254 Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/mediatek/mt8183/mt6358.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index cee9ef2239..4ab0e7ed76 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -874,6 +874,7 @@ void pmic_set_vcore_vol(unsigned int vcore_uv)
pwrap_write_field(PMIC_VCORE_OP_EN, 1, 0x7F, 0);
pwrap_write_field(PMIC_VCORE_VOSEL, vol_reg, 0x7F, 0);
+ udelay(1);
}
unsigned int pmic_get_vdram1_vol(void)
@@ -895,6 +896,7 @@ void pmic_set_vdram1_vol(unsigned int vdram_uv)
pwrap_write_field(PMIC_VDRAM1_OP_EN, 1, 0x7F, 0);
pwrap_write_field(PMIC_VDRAM1_VOSEL, vol_reg, 0x7F, 0);
+ udelay(1);
}
unsigned int pmic_get_vddq_vol(void)