diff options
| author | Michael Niewöhner <foss@mniewoehner.de> | 2024-02-24 11:25:24 +0100 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-02-29 03:13:44 +0000 |
| commit | e2d6f7e4d707160b9dba6b12419671ec14825628 (patch) | |
| tree | f49b14a2aa4bf4ccc690facacf6eca1cc076d99b | |
| parent | 98cec2a2c9eb3fc9b37dd016d5b450368c84f3e2 (diff) | |
mb/clevo/tgl-u: hda_verbs: correct vendor value comments
The vendor vendor values for the hda verbs´ location field were
decoded wrong because of relying on the wrong bit shift value in
`device/azalia_device.h`. Since this was fixed now, correct the
comments.
Change-Id: I45b1d09d5a11b357ac2a20ef448ea642540cdc99
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80720
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
| -rw-r--r-- | src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c b/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c index db9da04235..b6bf5c5b55 100644 --- a/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c +++ b/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c @@ -13,7 +13,7 @@ const u32 cim_verb_data[] = { /* Microphone (display lid), vendor value: 0x90a60130 */ AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_DESC( AZALIA_INTEGRATED, - AZALIA_MOBILE_LID_INSIDE, /* vendor: AZALIA_SEPARATE_CHASSIS */ + AZALIA_MOBILE_LID_INSIDE, /* vendor: AZALIA_INTERNAL */ AZALIA_MIC_IN, AZALIA_OTHER_DIGITAL, AZALIA_COLOR_UNKNOWN, @@ -24,7 +24,7 @@ const u32 cim_verb_data[] = { /* Integrated speakers, vendor value: 0x90170110 */ AZALIA_PIN_CFG(0, 0x14, AZALIA_PIN_DESC( AZALIA_INTEGRATED, - AZALIA_LOCATION_OTHER | AZALIA_BOTTOM, /* vendor: AZALIA_SEPARATE_CHASSIS */ + AZALIA_LOCATION_OTHER | AZALIA_BOTTOM, /* vendor: AZALIA_INTERNAL */ AZALIA_SPEAKER, AZALIA_OTHER_ANALOG, AZALIA_COLOR_UNKNOWN, @@ -47,11 +47,11 @@ const u32 cim_verb_data[] = { /* ext. Microphone, vendor value: 0x411111f0, linux override: 0x01a1913c */ AZALIA_PIN_CFG(0, 0x1a, AZALIA_PIN_DESC( AZALIA_JACK, - /* vendor: AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_REAR */ + /* linux: AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_REAR */ AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, AZALIA_MIC_IN, AZALIA_STEREO_MONO_1_8, - AZALIA_BLACK, /* vendor: AZALIA_PINK */ + AZALIA_BLACK, /* linux: AZALIA_PINK */ AZALIA_NO_JACK_PRESENCE_DETECT, 3, 12) ), |