diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2024-05-24 17:44:57 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2024-05-27 14:49:22 +0000 |
| commit | dfad318095e76031ffb2d7695f45dd1f88346934 (patch) | |
| tree | 020a79288a9121cf5547891fd93fd3f04d274c06 | |
| parent | a0d453fa4d77bd6e924041d486cc0d681a4f8440 (diff) | |
acpi/acpi_apic;arch/x86/acpi: better document ACPI_NO_PCAT_8259 case
Both acpi_create_madt_sci_override and acpi_sci_int have special
handling for the ACPI_NO_PCAT_8259 case, but those cases weren't exactly
obvious, so add a comment with the reason for that.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia6dcf59d5ab9226c61e9c4af95a73a07771b71d1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82643
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/acpi/acpi_apic.c | 2 | ||||
| -rw-r--r-- | src/arch/x86/acpi.c | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index b47586dedc..fe0459b559 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -127,6 +127,8 @@ static int acpi_create_madt_sci_override(acpi_madt_irqoverride_t *irqoverride) ioapic_get_sci_pin(&gsi, &irq, &flags); + /* In systems without 8259, the SCI_INT field in the FADT contains the SCI GSI number + instead of the 8259 IRQ number */ if (!CONFIG(ACPI_HAVE_PCAT_8259)) irq = gsi; diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 2497143680..82cbf205a7 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -12,7 +12,8 @@ static u16 acpi_sci_int(void) ioapic_get_sci_pin(&gsi, &irq, &flags); - /* ACPI Release 6.5, 5.2.9 and 5.2.15.5. */ + /* In systems without 8259, the SCI_INT field in the FADT contains the SCI GSI number + instead of the 8259 IRQ number */ if (!CONFIG(ACPI_HAVE_PCAT_8259)) return gsi; |