diff options
| author | Jeremy Compostella <jeremy.compostella@intel.com> | 2023-08-02 16:59:03 -0700 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-08-05 16:12:37 +0000 |
| commit | d86260a134575b083f35103e1cd5c7c7ad883bce (patch) | |
| tree | 5998245b4a715bc1f8f3fffb64693dad0462a3d4 | |
| parent | 1d3e6eba02b074cf02615037694563db8854d3f1 (diff) | |
commonlib/fsp_relocate: Fix pe_relocate() return value on success
Similarly to te_relocate(), on success pe_relocate() should return 0.
It has never been an issue so far as pe_relocate() return value is not
tested.
Change-Id: I8e531662952d12e1f0ffa34042dab778ea602bfc
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76891
Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Anil Kumar K <anil.kumar.k@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
| -rw-r--r-- | src/commonlib/fsp_relocate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index c7c4b5a9ef..379930b22b 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -275,7 +275,7 @@ static int pe_relocate(uintptr_t new_addr, void *pe, void *fsp, size_t fih_off) img_base_off += delta; write_le32(&ophdr->ImageBase, img_base_off); - return -1; + return 0; } static int te_relocate(uintptr_t new_addr, void *te) |