diff options
| author | Jonathon Hall <jonathon.hall@puri.sm> | 2022-12-20 11:07:19 -0500 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-05-03 21:51:01 +0000 |
| commit | cc991c58cf409d63cdf2d4c1fba978c97842b989 (patch) | |
| tree | 03707353e60a4f55ca6480487fcd93bfd737b85f | |
| parent | 543bba8f8f6789dfb8d26a099695ffef2dd649ae (diff) | |
mb/purism/librem_cnl: Remove unneeded explicit PNP enable for UART
Remove explicit PNP 6e.1 configuration for UART. This had no effect,
the SuperIO is actually on I/O port 2e. Enabling the 8250IO driver is
sufficient to use the UART, the UART device is enabled by default.
Test: Build Mini v2 with and without CONFIG_ENABLE_EC_UART1, boot and
check output on serial.
Change-Id: Idbb39c81cadd633f4718f0682d231dc578d20325
Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74362
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c | 13 |
2 files changed, 0 insertions, 14 deletions
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc b/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc index 59020ef001..20ff43819f 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc @@ -2,4 +2,3 @@ all-y += die.c smm-y += die.c -bootblock-$(CONFIG_ENABLE_EC_UART1) += com_init.c diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c deleted file mode 100644 index 6d0f79f843..0000000000 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <bootblock_common.h> -#include <device/pnp_ops.h> - -#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */ - -void bootblock_mainboard_early_init(void) -{ - /* Enable the serial port inside the EC */ - pnp_set_logical_device(SERIAL_DEV); - pnp_set_enable(SERIAL_DEV, 1); -} |