diff options
| author | Nico Huber <nico.huber@secunet.com> | 2016-09-20 13:59:38 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2016-09-21 17:01:54 +0200 |
| commit | cc414dd47fd227962bded5605d6a277bb7b05939 (patch) | |
| tree | cd18160ac90f2ad55dcd324750f3208e6ae6e986 | |
| parent | 152e78e79421224c42aa09b875792f8583c3ccb3 (diff) | |
buildgcc: Fix GNU getopt usage
Looks like this never worked correctly: There are three argument formats
to GNU getopt and none of them matches what we fed it. The missing
double dash before the `set` arguments proves that we always called it
with parameters that `getopt` did NOT parse.
Change-Id: Ib8343976ef31774b18567a9fc9745a9f58dd287a
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/16679
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins)
| -rwxr-xr-x | util/crossgcc/buildgcc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 5b405c0c73..af6cbe2f11 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -690,8 +690,8 @@ getopt - > /dev/null 2>/dev/null || gcc -o getopt getopt.c getoptbrand="$(getopt -V | sed -e '1!d' -e 's,^\(......\).*,\1,')" if [ "${getoptbrand}" = "getopt" ]; then # Detected GNU getopt that supports long options. - args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported:,urls,nocolor Vhcd:bp:l:P:j:D:tSys:un -- "$@") - eval set "$args" + args=$(getopt -l version,help,clean,directory:,bootstrap,platform:,languages:,package:,jobs:,destdir:,savetemps,scripting,ccache,supported:,urls,nocolor -o Vhcd:bp:l:P:j:D:tSys:un -- "$@") + eval set -- "$args" else # Detected non-GNU getopt args=$(getopt Vhcd:bp:l:P:j:D:tSys:un $*) |