diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2023-10-22 13:32:28 -0500 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-10-24 13:15:55 +0000 |
| commit | c5a22f173b737820229407830d9c7f69f10fc0dc (patch) | |
| tree | 7a1383587a42893a7e387883b782724060cd2c0c | |
| parent | 331fa19dcf43e9f263646680eaedb7c8058216b5 (diff) | |
mb/google/hatch: Default I2C3 (proximity sensor) to off in baseboard
Default I2C3 (proximity sensor) to off in baseboard, since all variants
which use one already enable it in their override tree. This allows
variants which do not use it (the majority) to drop it from their
override trees.
Change-Id: If17cb4538a7f64d019e4e28285fb8977de72252f
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78549
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Yuchen He <yuchenhe126@gmail.com>
8 files changed, 1 insertions, 15 deletions
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 739caacdf8..76552ec300 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -217,7 +217,6 @@ chip soc/intel/cannonlake device i2c 5d on end end end # I2C #1 - device pci 15.3 off end # I2C #3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 79337041ac..d0d61bde11 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -293,7 +293,7 @@ chip soc/intel/cannonlake device pci 15.0 on end # I2C #0 device pci 15.1 on end # I2C #1 device pci 15.2 off end # I2C #2 - device pci 15.3 on end # I2C #3 + device pci 15.3 off end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 097e02409a..706cbdcc63 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -143,7 +143,6 @@ chip soc/intel/cannonlake device i2c 15 on end end end # I2C #1 - device pci 15.3 off end # I2C #3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index ec06e018ca..ac54091a31 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -136,9 +136,6 @@ chip soc/intel/cannonlake end end # I2C 1 - # I2C #3 unused - device pci 15.3 off end - device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb b/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb index 8141486259..a6e62e44b0 100644 --- a/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb @@ -148,9 +148,6 @@ chip soc/intel/cannonlake end end # I2C 1 - # I2C #3 unused - device pci 15.3 off end - device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 33d81dfb86..de2c803945 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -167,7 +167,6 @@ chip soc/intel/cannonlake device i2c 15 on end end end # I2C #1 - device pci 15.3 off end # I2C #3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 547383ff1f..8c622c8116 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -186,7 +186,6 @@ chip soc/intel/cannonlake device generic 0 on end end end # I2C #1 - device pci 15.3 off end # I2C #3 unused device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/hatch/variants/palkia/overridetree.cb b/src/mainboard/google/hatch/variants/palkia/overridetree.cb index b6920e98ae..060f5e4c63 100644 --- a/src/mainboard/google/hatch/variants/palkia/overridetree.cb +++ b/src/mainboard/google/hatch/variants/palkia/overridetree.cb @@ -151,10 +151,6 @@ chip soc/intel/cannonlake device i2c 10 on end end end #I2C 2 - - # I2C #3 unused - device pci 15.3 off end - device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" |