summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <edward.ocallaghan@koparo.com>2015-03-26 20:10:09 +1100
committerEdward O'Callaghan <edward.ocallaghan@koparo.com>2015-04-09 19:34:02 +0200
commitc1a9dfe85be5aa7c634bd0facde2ed1e77d76bde (patch)
tree7af13544c96974df265083ff1744775f3f492aa5
parentb95be26096d81832620e4768c223887f69de118b (diff)
soc: Use DEVICE_NOOP macro formalism over static stub func
Change-Id: Ice7e27230010ffc48948f952394e849533f94085 Signed-off-by: Edward O'Callaghan <edward.ocallaghan@koparo.com> Reviewed-on: http://review.coreboot.org/8989 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones@se-eng.com>
-rw-r--r--src/soc/nvidia/tegra132/soc.c8
-rw-r--r--src/soc/rockchip/rk3288/soc.c16
2 files changed, 5 insertions, 19 deletions
diff --git a/src/soc/nvidia/tegra132/soc.c b/src/soc/nvidia/tegra132/soc.c
index b3841135f3..1072467818 100644
--- a/src/soc/nvidia/tegra132/soc.c
+++ b/src/soc/nvidia/tegra132/soc.c
@@ -86,14 +86,10 @@ static void soc_init(device_t dev)
arch_initialize_cpus(dev, &cntrl_ops);
}
-static void soc_noop(device_t dev)
-{
-}
-
static struct device_operations soc_ops = {
.read_resources = soc_read_resources,
- .set_resources = soc_noop,
- .enable_resources = soc_noop,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = soc_init,
.scan_bus = NULL,
};
diff --git a/src/soc/rockchip/rk3288/soc.c b/src/soc/rockchip/rk3288/soc.c
index f5e52eb4e2..e379644680 100644
--- a/src/soc/rockchip/rk3288/soc.c
+++ b/src/soc/rockchip/rk3288/soc.c
@@ -35,21 +35,11 @@ static void soc_enable(device_t dev)
ram_resource(dev, 0, RAM_BASE_KB, RAM_SIZE_KB);
}
-static void soc_init(device_t dev)
-{
-
-}
-
-static void soc_noop(device_t dev)
-{
-
-}
-
static struct device_operations soc_ops = {
- .read_resources = soc_noop,
- .set_resources = soc_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
.enable_resources = soc_enable,
- .init = soc_init,
+ .init = DEVICE_NOOP,
.scan_bus = 0,
};