diff options
| author | Maximilian Brune <maximilian.brune@9elements.com> | 2024-08-15 23:08:33 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2024-10-07 20:20:43 +0000 |
| commit | b6974ab13deccb89d8fa749a37ad97fc951eddc8 (patch) | |
| tree | 9a7141c53db5e55a46c1715263684a3eaaf77229 | |
| parent | 53b7c0217098a73a1f6da848743674738354827d (diff) | |
arch/x86: Remove CONFIG_DEBUG_NULL_DEREF_HALT
For more than 2 years the option has been unconfigurable.
Since no one seems to have fixed that, the options seems to be
not needed by anyone. So instead of making it configurable now,
we can just as well remove it.
Change-Id: I4055d497c7c23e148d2a09f216c7b910a9b3ea9b
Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83934
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
| -rw-r--r-- | src/arch/x86/Kconfig | 8 | ||||
| -rw-r--r-- | src/arch/x86/null_breakpoint.c | 4 |
2 files changed, 2 insertions, 10 deletions
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 2db526e34c..e99b3af7c2 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -368,14 +368,6 @@ config DEBUG_NULL_DEREF_BREAKPOINTS_IN_ALL_STAGES default y depends on DEBUG_NULL_DEREF_BREAKPOINTS && DEBUG_HW_BREAKPOINTS_IN_ALL_STAGES -config DEBUG_NULL_DEREF_HALT - bool - default n - depends on DEBUG_NULL_DEREF_BREAKPOINTS - help - When enabled null dereferences and instruction fetches will halt execution. - Otherwise an error will be printed. - # Some EC need an "EC firmware pointer" (a data structure hinting the address # of its firmware blobs) being put at a fixed position. Its space # (__section__(".ecfw_ptr")) should be reserved if it lies in the range of a diff --git a/src/arch/x86/null_breakpoint.c b/src/arch/x86/null_breakpoint.c index 43e3727448..44c7ae91c4 100644 --- a/src/arch/x86/null_breakpoint.c +++ b/src/arch/x86/null_breakpoint.c @@ -12,7 +12,7 @@ static struct breakpoint_handle null_fetch_bp; static int handle_fetch_breakpoint(struct breakpoint_handle handle, struct eregs *regs) { printk(BIOS_ERR, "Instruction fetch from address zero\n"); - return CONFIG(DEBUG_NULL_DEREF_HALT); + return 0; } static int handle_deref_breakpoint(struct breakpoint_handle handle, struct eregs *regs) @@ -22,7 +22,7 @@ static int handle_deref_breakpoint(struct breakpoint_handle handle, struct eregs #else printk(BIOS_ERR, "Null dereference at eip: 0x%x\n", regs->eip); #endif - return CONFIG(DEBUG_NULL_DEREF_HALT); + return 0; } static void create_deref_breakpoint(void) |