diff options
| author | Elyes Haouas <ehaouas@noos.fr> | 2022-02-16 14:42:19 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-02-21 15:26:30 +0000 |
| commit | b55ac09ce34fe407923a14cc768f8c69918c42b2 (patch) | |
| tree | c297bae743782918a9b7c9983d1181beee6f601f | |
| parent | 3a5e6f529c286f7f5da2659347c7d9177fb311cd (diff) | |
[acpi]{include,soc/amd,southbridge/amd}: Clarify ARM_boot_arch in comments
Change-Id: I8b209da90b5a591f62e760961c64c4c63e6ef65b
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62040
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/include/acpi/acpi.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/picasso/acpi.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/acpi.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/agesa/hudson/fadt.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/cimx/sb800/fadt.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/pi/hudson/fadt.c | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index c5a04f0acc..49dd0c651c 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -746,7 +746,7 @@ typedef struct acpi_fadt { u32 flags; acpi_addr_t reset_reg; u8 reset_value; - u16 ARM_boot_arch; /* Revision 6 only, Revision 5: Must be zero */ + u16 ARM_boot_arch; /* Must be zero if ACPI Revision <= 5.0 */ u8 FADT_MinorVersion; /* Must be zero if ACPI Revision <= 5.0 */ u32 x_firmware_ctl_l; u32 x_firmware_ctl_h; diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index bab563c26e..2f55aeca44 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -105,7 +105,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */ - fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ + fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index c3c77fca13..ec22704838 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -97,7 +97,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ + fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c index 7461fe0f76..fb887980da 100644 --- a/src/southbridge/amd/agesa/hudson/fadt.c +++ b/src/southbridge/amd/agesa/hudson/fadt.c @@ -62,7 +62,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ + fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c index 8fe8bfde8e..101c2bf317 100644 --- a/src/southbridge/amd/cimx/sb800/fadt.c +++ b/src/southbridge/amd/cimx/sb800/fadt.c @@ -86,7 +86,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ + fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c index 3f4f0cb891..a30202a74f 100644 --- a/src/southbridge/amd/pi/hudson/fadt.c +++ b/src/southbridge/amd/pi/hudson/fadt.c @@ -62,7 +62,7 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ + fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ |