summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRizwan Qureshi <rizwan.qureshi@intel.corp-partner.google.com>2017-09-25 17:35:15 +0530
committerMartin Roth <martinroth@google.com>2017-10-05 17:46:15 +0000
commitb3e18c7a434700ace381443a0e16718d8c6af7f6 (patch)
tree6621c6020ab66951a53ce20bd1d46eaa637116f6
parentbd55c02a2398e2ce95cb06ff9f1e3fb1c20d0ab8 (diff)
soc/intel/skylake: Add config for mbx command for Intersil VR C-state issues
Config for activating VR mailbox command for Intersil VR C-state issues. 0 - no mailbox command sent. 1 - VR mailbox command sent for IA/GT rails only. 2 - VR mailbox command sent for IA/GT/SA rails. BUG=b:65499724 BRANCH=none TEST= build and boot soraka. Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4 Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com> Reviewed-on: https://review.coreboot.org/21680 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/skylake/chip.h8
-rw-r--r--src/soc/intel/skylake/chip_fsp20.c8
2 files changed, 16 insertions, 0 deletions
diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 0ade01cd1e..022306cef3 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -518,6 +518,14 @@ struct soc_intel_skylake_config {
/* coreboot handles locking */
CHIPSET_LOCKDOWN_COREBOOT,
} chipset_lockdown;
+
+ /*
+ * Activates VR mailbox command for Intersil VR C-state issues.
+ * 0 - no mailbox command sent.
+ * 1 - VR mailbox command sent for IA/GT rails only.
+ * 2 - VR mailbox command sent for IA/GT/SA rails.
+ */
+ u8 IslVrCmd;
};
typedef struct soc_intel_skylake_config config_t;
diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index b1697ae35f..ac60125f70 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -271,6 +271,14 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
*/
params->SendVrMbxCmd1 = config->SendVrMbxCmd;
+ /*
+ * Activates VR mailbox command for Intersil VR C-state issues.
+ * 0 - no mailbox command sent.
+ * 1 - VR mailbox command sent for IA/GT rails only.
+ * 2 - VR mailbox command sent for IA/GT/SA rails.
+ */
+ params->IslVrCmd = config->IslVrCmd;
+
/* Acoustic Noise Mitigation */
params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;
params->SlowSlewRateForIa = config->SlowSlewRateForIa;