summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <martinroth@chromium.org>2021-04-23 12:24:35 -0600
committerMartin Roth <martinroth@google.com>2021-04-26 21:44:47 +0000
commit9c17665aaac5890df2926230ae32f3cb608044d8 (patch)
tree41d5fa78fff7d1cc5d7d3ea8a68b94ef87690a19
parent029d997b6eb0c784b844bf554dec5c33286b6507 (diff)
soc/amd/cezanne: Update STAPM vars with units
Like the Picasso platform, it's very useful to have units on these variables. BUG=b:185209734 TEST=Build & Boot Signed-off-by: Martin Roth <martinroth@chromium.org> Change-Id: I592c807c5e9a2c17b1c5959e56a01237352c5204 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52649 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Peers <epeers@google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org>
-rw-r--r--src/soc/amd/cezanne/chip.h8
-rw-r--r--src/soc/amd/cezanne/fsp_m_params.c8
2 files changed, 8 insertions, 8 deletions
diff --git a/src/soc/amd/cezanne/chip.h b/src/soc/amd/cezanne/chip.h
index 4c5118e914..6b6a28f749 100644
--- a/src/soc/amd/cezanne/chip.h
+++ b/src/soc/amd/cezanne/chip.h
@@ -50,11 +50,11 @@ struct soc_amd_cezanne_config {
uint16_t stt_error_rate_coefficient;
uint8_t stapm_boost;
- uint32_t stapm_time_constant;
+ uint32_t stapm_time_constant_s;
uint32_t apu_only_sppt_limit;
- uint32_t sustained_power_limit;
- uint32_t fast_ppt_limit;
- uint32_t slow_ppt_limit;
+ uint32_t sustained_power_limit_mW;
+ uint32_t fast_ppt_limit_mW;
+ uint32_t slow_ppt_limit_mW;
uint32_t slow_ppt_time_constant_s;
uint32_t thermctl_limit_degreeC;
diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c
index 964ec1880c..2528086977 100644
--- a/src/soc/amd/cezanne/fsp_m_params.c
+++ b/src/soc/amd/cezanne/fsp_m_params.c
@@ -93,11 +93,11 @@ void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
/* all following fields being 0 is a valid config */
mcfg->stapm_boost = config->stapm_boost;
- mcfg->stapm_time_constant = config->stapm_time_constant;
+ mcfg->stapm_time_constant = config->stapm_time_constant_s;
mcfg->apu_only_sppt_limit = config->apu_only_sppt_limit;
- mcfg->sustained_power_limit = config->sustained_power_limit;
- mcfg->fast_ppt_limit = config->fast_ppt_limit;
- mcfg->slow_ppt_limit = config->slow_ppt_limit;
+ mcfg->sustained_power_limit = config->sustained_power_limit_mW;
+ mcfg->fast_ppt_limit = config->fast_ppt_limit_mW;
+ mcfg->slow_ppt_limit = config->slow_ppt_limit_mW;
mcfg->slow_ppt_time_constant = config->slow_ppt_time_constant_s;
mcfg->thermctl_limit = config->thermctl_limit_degreeC;