diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2021-10-08 13:10:38 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-18 12:38:12 +0000 |
| commit | 9ae922abf728814e10781a71f35803bd53d57524 (patch) | |
| tree | 927a25850c6709a0409493fd029f8b3d1bfbeb6f | |
| parent | db3e4b943a826eacbc2e38e0866b52cbaea1f19b (diff) | |
cpu/x86/cpu_info.S: Remove ebx save/restore
The push/pop of %ebx was only added because smm_stub saves the canary
value in it. Now that we no longer use cpu_info in smm, we no longer
need to save the register.
BUG=b:179699789
TEST=Boot guybrush to the OS
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I554dbe016db8b1c61246c8ffc7fa252b2542ba92
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58205
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
| -rw-r--r-- | src/cpu/x86/cpu_info.S.inc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/cpu/x86/cpu_info.S.inc b/src/cpu/x86/cpu_info.S.inc index fc3e26d178..9ffdd84444 100644 --- a/src/cpu/x86/cpu_info.S.inc +++ b/src/cpu/x86/cpu_info.S.inc @@ -28,12 +28,11 @@ * @desc_index: Index of the descriptor in the table. Defaults to 0. Must be a * register if specified. * - * Clobbers %eax. + * Clobbers %eax, %ebx. */ .macro set_segment_descriptor_base desc_array:req, base:req, desc_index mov \base, %eax - push %ebx /* preserve ebx */ mov \desc_array, %ebx .ifb \desc_index @@ -50,5 +49,4 @@ movb %al, 7(%ebx, \desc_index, 8) .endif - pop %ebx .endm |