summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-11-06 16:13:15 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-11-11 06:25:12 +0000
commit9a3bde0581a574956dd57ca24683c41ac7e0edfc (patch)
tree3d4e3e375f82fcf79d571fd4220967af1517f10a
parentbc94d60924483606763a68b313c57559ae759dd7 (diff)
ChromeOS: Replace with or add <types.h>
It's commented in <types.h> that it shall provide <commonlib/helpers.h>. Fix for ARRAY_SIZE() in bulk, followup works will reduce the number of other includes these files have. Change-Id: I2572aaa2cf4254f0dea6698cba627de12725200f Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58996 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
-rw-r--r--src/mainboard/amd/majolica/chromeos.c1
-rw-r--r--src/mainboard/emulation/qemu-q35/chromeos.c1
-rw-r--r--src/mainboard/google/auron/chromeos.c1
-rw-r--r--src/mainboard/google/beltino/chromeos.c1
-rw-r--r--src/mainboard/google/brya/chromeos.c1
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brask/gpio.c2
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brya/gpio.c2
-rw-r--r--src/mainboard/google/butterfly/chromeos.c1
-rw-r--r--src/mainboard/google/cyan/chromeos.c1
-rw-r--r--src/mainboard/google/daisy/chromeos.c1
-rw-r--r--src/mainboard/google/dedede/chromeos.c1
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/deltaur/chromeos.c1
-rw-r--r--src/mainboard/google/drallion/chromeos.c1
-rw-r--r--src/mainboard/google/eve/chromeos.c1
-rw-r--r--src/mainboard/google/fizz/chromeos.c1
-rw-r--r--src/mainboard/google/fizz/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/glados/chromeos.c1
-rw-r--r--src/mainboard/google/guybrush/chromeos.c1
-rw-r--r--src/mainboard/google/hatch/chromeos.c1
-rw-r--r--src/mainboard/google/hatch/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/jecht/chromeos.c1
-rw-r--r--src/mainboard/google/kahlee/chromeos.c1
-rw-r--r--src/mainboard/google/link/chromeos.c1
-rw-r--r--src/mainboard/google/octopus/chromeos.c1
-rw-r--r--src/mainboard/google/octopus/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/parrot/chromeos.c1
-rw-r--r--src/mainboard/google/peach_pit/chromeos.c1
-rw-r--r--src/mainboard/google/poppy/chromeos.c1
-rw-r--r--src/mainboard/google/poppy/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/rambi/chromeos.c1
-rw-r--r--src/mainboard/google/reef/chromeos.c1
-rw-r--r--src/mainboard/google/reef/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/reef/variants/coral/gpio.c2
-rw-r--r--src/mainboard/google/sarien/chromeos.c1
-rw-r--r--src/mainboard/google/slippy/chromeos.c1
-rw-r--r--src/mainboard/google/stout/chromeos.c1
-rw-r--r--src/mainboard/google/volteer/chromeos.c1
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/zork/chromeos.c1
-rw-r--r--src/mainboard/intel/adlrvp/chromeos.c1
-rw-r--r--src/mainboard/intel/adlrvp/gpio.c2
-rw-r--r--src/mainboard/intel/baskingridge/chromeos.c1
-rw-r--r--src/mainboard/intel/coffeelake_rvp/chromeos.c1
-rw-r--r--src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/intel/emeraldlake2/chromeos.c1
-rw-r--r--src/mainboard/intel/glkrvp/chromeos.c1
-rw-r--r--src/mainboard/intel/glkrvp/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/intel/icelake_rvp/chromeos.c1
-rw-r--r--src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c2
-rw-r--r--src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c2
-rw-r--r--src/mainboard/intel/jasperlake_rvp/chromeos.c1
-rw-r--r--src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c2
-rw-r--r--src/mainboard/intel/kblrvp/chromeos.c1
-rw-r--r--src/mainboard/intel/kunimitsu/chromeos.c1
-rw-r--r--src/mainboard/intel/shadowmountain/chromeos.c1
-rw-r--r--src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/intel/strago/chromeos.c1
-rw-r--r--src/mainboard/intel/tglrvp/chromeos.c1
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c2
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c2
-rw-r--r--src/mainboard/intel/wtm2/chromeos.c1
-rw-r--r--src/mainboard/samsung/lumpy/chromeos.c1
-rw-r--r--src/mainboard/samsung/stumpy/chromeos.c1
64 files changed, 64 insertions, 19 deletions
diff --git a/src/mainboard/amd/majolica/chromeos.c b/src/mainboard/amd/majolica/chromeos.c
index e5f3b5cc14..14f89d182e 100644
--- a/src/mainboard/amd/majolica/chromeos.c
+++ b/src/mainboard/amd/majolica/chromeos.c
@@ -3,6 +3,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/emulation/qemu-q35/chromeos.c b/src/mainboard/emulation/qemu-q35/chromeos.c
index bb0ffeea95..cb904a0656 100644
--- a/src/mainboard/emulation/qemu-q35/chromeos.c
+++ b/src/mainboard/emulation/qemu-q35/chromeos.c
@@ -2,6 +2,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/auron/chromeos.c b/src/mainboard/google/auron/chromeos.c
index 2274ff7d28..3132fd7da5 100644
--- a/src/mainboard/google/auron/chromeos.c
+++ b/src/mainboard/google/auron/chromeos.c
@@ -2,6 +2,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <soc/chromeos.h>
#include <southbridge/intel/lynxpoint/lp_gpio.h>
diff --git a/src/mainboard/google/beltino/chromeos.c b/src/mainboard/google/beltino/chromeos.c
index a33caca37a..c51af1ad1a 100644
--- a/src/mainboard/google/beltino/chromeos.c
+++ b/src/mainboard/google/beltino/chromeos.c
@@ -6,6 +6,7 @@
#include <device/device.h>
#include <southbridge/intel/lynxpoint/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#define GPIO_SPI_WP 58
diff --git a/src/mainboard/google/brya/chromeos.c b/src/mainboard/google/brya/chromeos.c
index e0a13b8856..bf7f9eb21f 100644
--- a/src/mainboard/google/brya/chromeos.c
+++ b/src/mainboard/google/brya/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
index d9cbdb0d1d..ba4bbf86f9 100644
--- a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <soc/gpio.h>
#include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
index 73fad72480..a28f873ed9 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <soc/gpio.h>
#include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c
index 356e97b7b5..2de55b0dff 100644
--- a/src/mainboard/google/butterfly/chromeos.c
+++ b/src/mainboard/google/butterfly/chromeos.c
@@ -8,6 +8,7 @@
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
#include <ec/quanta/ene_kb3940q/ec.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "ec.h"
diff --git a/src/mainboard/google/cyan/chromeos.c b/src/mainboard/google/cyan/chromeos.c
index 14efdc3e4f..f0c1446160 100644
--- a/src/mainboard/google/cyan/chromeos.c
+++ b/src/mainboard/google/cyan/chromeos.c
@@ -5,6 +5,7 @@
#include <device/mmio.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* The WP status pin lives on MF_ISH_GPIO_4 */
diff --git a/src/mainboard/google/daisy/chromeos.c b/src/mainboard/google/daisy/chromeos.c
index 7599295f1f..00fa126434 100644
--- a/src/mainboard/google/daisy/chromeos.c
+++ b/src/mainboard/google/daisy/chromeos.c
@@ -5,6 +5,7 @@
#include <ec/google/chromeec/ec_commands.h>
#include <soc/cpu.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <bootmode.h>
diff --git a/src/mainboard/google/dedede/chromeos.c b/src/mainboard/google/dedede/chromeos.c
index 0d75ac3cfd..e5ae163809 100644
--- a/src/mainboard/google/dedede/chromeos.c
+++ b/src/mainboard/google/dedede/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index 9b3bd7062d..864bb29cf7 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/google/deltaur/chromeos.c b/src/mainboard/google/deltaur/chromeos.c
index dbdb273c1a..3d17a6cfb2 100644
--- a/src/mainboard/google/deltaur/chromeos.c
+++ b/src/mainboard/google/deltaur/chromeos.c
@@ -8,6 +8,7 @@
#include <gpio.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <security/tpm/tss.h>
#include <device/device.h>
diff --git a/src/mainboard/google/drallion/chromeos.c b/src/mainboard/google/drallion/chromeos.c
index e3a9cd3788..6122b85a5b 100644
--- a/src/mainboard/google/drallion/chromeos.c
+++ b/src/mainboard/google/drallion/chromeos.c
@@ -6,6 +6,7 @@
#include <gpio.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <security/tpm/tss.h>
#include <device/device.h>
diff --git a/src/mainboard/google/eve/chromeos.c b/src/mainboard/google/eve/chromeos.c
index 73eae78dc9..7c0cc96b3b 100644
--- a/src/mainboard/google/eve/chromeos.c
+++ b/src/mainboard/google/eve/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "gpio.h"
diff --git a/src/mainboard/google/fizz/chromeos.c b/src/mainboard/google/fizz/chromeos.c
index a9456e48e2..5ee822c22a 100644
--- a/src/mainboard/google/fizz/chromeos.c
+++ b/src/mainboard/google/fizz/chromeos.c
@@ -5,6 +5,7 @@
#include <gpio.h>
#include <baseboard/variants.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/fizz/variants/baseboard/gpio.c b/src/mainboard/google/fizz/variants/baseboard/gpio.c
index c448f05527..71546aaeba 100644
--- a/src/mainboard/google/fizz/variants/baseboard/gpio.c
+++ b/src/mainboard/google/fizz/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage */
diff --git a/src/mainboard/google/glados/chromeos.c b/src/mainboard/google/glados/chromeos.c
index acd4cd640a..1dff1caba6 100644
--- a/src/mainboard/google/glados/chromeos.c
+++ b/src/mainboard/google/glados/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/guybrush/chromeos.c b/src/mainboard/google/guybrush/chromeos.c
index 61313223fe..3e54fa4964 100644
--- a/src/mainboard/google/guybrush/chromeos.c
+++ b/src/mainboard/google/guybrush/chromeos.c
@@ -4,6 +4,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/hatch/chromeos.c b/src/mainboard/google/hatch/chromeos.c
index 354d8398e6..3401b82d97 100644
--- a/src/mainboard/google/hatch/chromeos.c
+++ b/src/mainboard/google/hatch/chromeos.c
@@ -7,6 +7,7 @@
#include <ec/google/chromeec/ec.h>
#include <gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index a3cf60f3f1..f9ffcd96ec 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -3,7 +3,7 @@
#include <acpi/acpi.h>
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
static const struct pad_config gpio_table[] = {
diff --git a/src/mainboard/google/jecht/chromeos.c b/src/mainboard/google/jecht/chromeos.c
index 5cfe9df74f..ff4cef6a60 100644
--- a/src/mainboard/google/jecht/chromeos.c
+++ b/src/mainboard/google/jecht/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <device/pci_ops.h>
#include <device/device.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <ec/google/chromeec/ec.h>
#include <soc/chromeos.h>
diff --git a/src/mainboard/google/kahlee/chromeos.c b/src/mainboard/google/kahlee/chromeos.c
index a386dd6982..0a465c98a4 100644
--- a/src/mainboard/google/kahlee/chromeos.c
+++ b/src/mainboard/google/kahlee/chromeos.c
@@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <bootmode.h>
#include <boot/coreboot_tables.h>
diff --git a/src/mainboard/google/link/chromeos.c b/src/mainboard/google/link/chromeos.c
index 540803ca1a..f4250cc247 100644
--- a/src/mainboard/google/link/chromeos.c
+++ b/src/mainboard/google/link/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/octopus/chromeos.c b/src/mainboard/google/octopus/chromeos.c
index d0ceabccd1..9c260ab60a 100644
--- a/src/mainboard/google/octopus/chromeos.c
+++ b/src/mainboard/google/octopus/chromeos.c
@@ -5,6 +5,7 @@
#include <boot/coreboot_tables.h>
#include <ec/google/chromeec/ec.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c
index e59931710f..d16c4e1b12 100644
--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c
+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c
@@ -3,7 +3,7 @@
#include <acpi/acpi.h>
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/*
diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c
index 03b0d476f3..77aa11a626 100644
--- a/src/mainboard/google/parrot/chromeos.c
+++ b/src/mainboard/google/parrot/chromeos.c
@@ -9,6 +9,7 @@
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
#include <ec/compal/ene932/ec.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "ec.h"
diff --git a/src/mainboard/google/peach_pit/chromeos.c b/src/mainboard/google/peach_pit/chromeos.c
index ebbfdd3cb4..07a13a31b5 100644
--- a/src/mainboard/google/peach_pit/chromeos.c
+++ b/src/mainboard/google/peach_pit/chromeos.c
@@ -6,6 +6,7 @@
#include <ec/google/chromeec/ec_commands.h>
#include <soc/cpu.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/poppy/chromeos.c b/src/mainboard/google/poppy/chromeos.c
index c9b91ad8b1..ff39fbf337 100644
--- a/src/mainboard/google/poppy/chromeos.c
+++ b/src/mainboard/google/poppy/chromeos.c
@@ -6,6 +6,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c
index d7be2c693a..d3df99e44f 100644
--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c
+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage */
diff --git a/src/mainboard/google/rambi/chromeos.c b/src/mainboard/google/rambi/chromeos.c
index f9a171820d..773a807f95 100644
--- a/src/mainboard/google/rambi/chromeos.c
+++ b/src/mainboard/google/rambi/chromeos.c
@@ -3,6 +3,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* The WP status pin lives on GPIO_SSUS_6 which is pad 36 in the SUS well. */
diff --git a/src/mainboard/google/reef/chromeos.c b/src/mainboard/google/reef/chromeos.c
index a45ccdd9e0..d258678d7c 100644
--- a/src/mainboard/google/reef/chromeos.c
+++ b/src/mainboard/google/reef/chromeos.c
@@ -4,6 +4,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/reef/variants/baseboard/gpio.c b/src/mainboard/google/reef/variants/baseboard/gpio.c
index fb32b3afff..9bb3e45fe5 100644
--- a/src/mainboard/google/reef/variants/baseboard/gpio.c
+++ b/src/mainboard/google/reef/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/*
diff --git a/src/mainboard/google/reef/variants/coral/gpio.c b/src/mainboard/google/reef/variants/coral/gpio.c
index 807d161475..de54929d4b 100644
--- a/src/mainboard/google/reef/variants/coral/gpio.c
+++ b/src/mainboard/google/reef/variants/coral/gpio.c
@@ -3,7 +3,7 @@
#include <acpi/acpi.h>
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/*
diff --git a/src/mainboard/google/sarien/chromeos.c b/src/mainboard/google/sarien/chromeos.c
index 3dc9f19668..170013a7b0 100644
--- a/src/mainboard/google/sarien/chromeos.c
+++ b/src/mainboard/google/sarien/chromeos.c
@@ -6,6 +6,7 @@
#include <gpio.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <security/tpm/tss.h>
#include <device/device.h>
diff --git a/src/mainboard/google/slippy/chromeos.c b/src/mainboard/google/slippy/chromeos.c
index 4fffd45b35..5453583e87 100644
--- a/src/mainboard/google/slippy/chromeos.c
+++ b/src/mainboard/google/slippy/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <southbridge/intel/lynxpoint/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c
index 07fdee3281..e68093f592 100644
--- a/src/mainboard/google/stout/chromeos.c
+++ b/src/mainboard/google/stout/chromeos.c
@@ -8,6 +8,7 @@
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "ec.h"
#include <ec/quanta/it8518/ec.h>
diff --git a/src/mainboard/google/volteer/chromeos.c b/src/mainboard/google/volteer/chromeos.c
index 5f87821393..20469d6297 100644
--- a/src/mainboard/google/volteer/chromeos.c
+++ b/src/mainboard/google/volteer/chromeos.c
@@ -5,6 +5,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index 164e9d2507..ac8c5c2706 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage */
diff --git a/src/mainboard/google/zork/chromeos.c b/src/mainboard/google/zork/chromeos.c
index cfb55a76d9..35c002d45c 100644
--- a/src/mainboard/google/zork/chromeos.c
+++ b/src/mainboard/google/zork/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <variant/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/adlrvp/chromeos.c b/src/mainboard/intel/adlrvp/chromeos.c
index 85807a1181..5fe89af99c 100644
--- a/src/mainboard/intel/adlrvp/chromeos.c
+++ b/src/mainboard/intel/adlrvp/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/adlrvp/gpio.c b/src/mainboard/intel/adlrvp/gpio.c
index 3a8e629f96..8a04bd959d 100644
--- a/src/mainboard/intel/adlrvp/gpio.c
+++ b/src/mainboard/intel/adlrvp/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c
index 2b140142b8..b6c41640ac 100644
--- a/src/mainboard/intel/baskingridge/chromeos.c
+++ b/src/mainboard/intel/baskingridge/chromeos.c
@@ -5,6 +5,7 @@
#include <device/device.h>
#include <southbridge/intel/lynxpoint/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos.c b/src/mainboard/intel/coffeelake_rvp/chromeos.c
index 1e02e3deb9..5c5003b7a9 100644
--- a/src/mainboard/intel/coffeelake_rvp/chromeos.c
+++ b/src/mainboard/intel/coffeelake_rvp/chromeos.c
@@ -6,6 +6,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
index b9d9429bf4..9e5f2436ad 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
+++ b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c
index e0f5fafbb0..58732b11fb 100644
--- a/src/mainboard/intel/emeraldlake2/chromeos.c
+++ b/src/mainboard/intel/emeraldlake2/chromeos.c
@@ -5,6 +5,7 @@
#include <device/device.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c
index 7878a2a801..dfdb66da84 100644
--- a/src/mainboard/intel/glkrvp/chromeos.c
+++ b/src/mainboard/intel/glkrvp/chromeos.c
@@ -5,6 +5,7 @@
#include <boot/coreboot_tables.h>
#include <ec/google/chromeec/ec.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include <soc/gpio.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
index eccfadeb21..0b2c6801af 100644
--- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
+++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/*
diff --git a/src/mainboard/intel/icelake_rvp/chromeos.c b/src/mainboard/intel/icelake_rvp/chromeos.c
index 8a8bc42087..6df26afced 100644
--- a/src/mainboard/intel/icelake_rvp/chromeos.c
+++ b/src/mainboard/intel/icelake_rvp/chromeos.c
@@ -6,6 +6,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c b/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c
index e631a86909..df068659c4 100644
--- a/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c
+++ b/src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c b/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c
index e631a86909..df068659c4 100644
--- a/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c
+++ b/src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.c b/src/mainboard/intel/jasperlake_rvp/chromeos.c
index 320f92a488..bf9a7bf8b9 100644
--- a/src/mainboard/intel/jasperlake_rvp/chromeos.c
+++ b/src/mainboard/intel/jasperlake_rvp/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c
index e3ad962ad7..82b3931aaf 100644
--- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c
+++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/kblrvp/chromeos.c b/src/mainboard/intel/kblrvp/chromeos.c
index df01242d12..902cb194fd 100644
--- a/src/mainboard/intel/kblrvp/chromeos.c
+++ b/src/mainboard/intel/kblrvp/chromeos.c
@@ -6,6 +6,7 @@
#include <gpio.h>
#include <soc/gpio.h>
#include <ec/google/chromeec/ec.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "gpio.h"
diff --git a/src/mainboard/intel/kunimitsu/chromeos.c b/src/mainboard/intel/kunimitsu/chromeos.c
index 3a99e255f9..09e9b7e44f 100644
--- a/src/mainboard/intel/kunimitsu/chromeos.c
+++ b/src/mainboard/intel/kunimitsu/chromeos.c
@@ -4,6 +4,7 @@
#include <boot/coreboot_tables.h>
#include <gpio.h>
#include <soc/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "gpio.h"
diff --git a/src/mainboard/intel/shadowmountain/chromeos.c b/src/mainboard/intel/shadowmountain/chromeos.c
index 052191fdc2..e71314ffe0 100644
--- a/src/mainboard/intel/shadowmountain/chromeos.c
+++ b/src/mainboard/intel/shadowmountain/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c b/src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c
index 2a7ce9cfda..f416e09004 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage */
diff --git a/src/mainboard/intel/strago/chromeos.c b/src/mainboard/intel/strago/chromeos.c
index ad23ea1aff..3f80b68034 100644
--- a/src/mainboard/intel/strago/chromeos.c
+++ b/src/mainboard/intel/strago/chromeos.c
@@ -3,6 +3,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#define WP_GPIO GP_E_22
diff --git a/src/mainboard/intel/tglrvp/chromeos.c b/src/mainboard/intel/tglrvp/chromeos.c
index cb9af47be2..4eeb679ac9 100644
--- a/src/mainboard/intel/tglrvp/chromeos.c
+++ b/src/mainboard/intel/tglrvp/chromeos.c
@@ -5,6 +5,7 @@
#include <bootmode.h>
#include <boot/coreboot_tables.h>
#include <gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios)
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
index 8bbd82ad58..f067af713a 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
index c577eca1f4..889d4e675e 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
@@ -2,7 +2,7 @@
#include <baseboard/gpio.h>
#include <baseboard/variants.h>
-#include <commonlib/helpers.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/
diff --git a/src/mainboard/intel/wtm2/chromeos.c b/src/mainboard/intel/wtm2/chromeos.c
index 996eee2f3c..5e01910e48 100644
--- a/src/mainboard/intel/wtm2/chromeos.c
+++ b/src/mainboard/intel/wtm2/chromeos.c
@@ -5,6 +5,7 @@
#include <device/device.h>
#include <soc/chromeos.h>
#include <southbridge/intel/lynxpoint/lp_gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
/* Compile-time settings for recovery mode. */
diff --git a/src/mainboard/samsung/lumpy/chromeos.c b/src/mainboard/samsung/lumpy/chromeos.c
index aa96153c29..ea9c75d9d1 100644
--- a/src/mainboard/samsung/lumpy/chromeos.c
+++ b/src/mainboard/samsung/lumpy/chromeos.c
@@ -7,6 +7,7 @@
#include <northbridge/intel/sandybridge/sandybridge.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#define GPIO_SPI_WP 24
diff --git a/src/mainboard/samsung/stumpy/chromeos.c b/src/mainboard/samsung/stumpy/chromeos.c
index c8fbf9866d..c15233cd26 100644
--- a/src/mainboard/samsung/stumpy/chromeos.c
+++ b/src/mainboard/samsung/stumpy/chromeos.c
@@ -6,6 +6,7 @@
#include <device/device.h>
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/common/gpio.h>
+#include <types.h>
#include <vendorcode/google/chromeos/chromeos.h>
#define GPIO_SPI_WP 68