diff options
| author | YH Lin <yueherngl@google.com> | 2019-02-26 09:33:50 -0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-02-27 11:10:49 +0000 |
| commit | 97278939fff8c7c572a373f3f7a515be193785bd (patch) | |
| tree | d71ab7c184aaae4410d891f1ff2fd7bcd3914b51 | |
| parent | e613d704d12592dfc371d81957a3d83b0742fa7d (diff) | |
flapjack: use sku_id 0 for un-provisioned board
Instead of using 2, 0 is now used for non-CBI provisioned board or
corrupted CBI board to confrom to the sku encoding.
BUG=b:123676982
BRANCH=kukui
TEST=test with un-provisioned board to verify the sku_id.
Signed-off-by: YH Lin <yueherngl@google.com>
Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce
Reviewed-on: https://review.coreboot.org/c/31623
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rw-r--r-- | src/mainboard/google/kukui/boardid.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c index 2af93c8a0a..b1d6736262 100644 --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -19,7 +19,8 @@ #include <ec/google/chromeec/ec.h> #include <stddef.h> -#define FLAPJACK_UNDEF_SKU_ID 2 /* For all un-provisioned Flapjack boards */ +/* For CBI un-provisioned/corrupted Flapjack board. */ +#define FLAPJACK_UNDEF_SKU_ID 0 static uint32_t get_index(unsigned int channel, uint32_t *cached_id) { @@ -67,7 +68,7 @@ uint32_t sku_id(void) { static uint32_t cached_sku_id = BOARD_ID_INIT; - /* On Flapjack, getting the SKU via CBI */ + /* On Flapjack, getting the SKU via CBI. */ if (IS_ENABLED(CONFIG_BOARD_GOOGLE_FLAPJACK)) { if (cached_sku_id == BOARD_ID_INIT && google_chromeec_cbi_get_sku_id(&cached_sku_id)) |