diff options
| author | Subrata Banik <subratabanik@google.com> | 2023-02-17 02:22:31 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2023-02-17 08:30:15 +0000 |
| commit | 8b223d43ce5e00b08fe19bdb044344b4e98e7a22 (patch) | |
| tree | 30b0eb34acf805acf2da87e0af4cfc68ee9dbde4 | |
| parent | eac71c0bcf49477c56c252d4c3ead0d6006e1ecf (diff) | |
soc/intel/cmn/acpi/pep: Add PCI device number for warning msg
This patch fixes the wrong warning msg around `Unknown min d_state`
with having proper PCI Bus/Device/Function number to help to parse
the log better.
With this patch:
[WARN ] Unknown min d_state for 20
[WARN ] Unknown min d_state for 50
[WARN ] Unknown min d_state for 98
[WARN ] Unknown min d_state for 9a
[WARN ] Unknown min d_state for f9
With this patch:
[WARN ] Unknown min d_state for PCI: 00:04.0
[WARN ] Unknown min d_state for PCI: 00:0a.0
[WARN ] Unknown min d_state for PCI: 00:13.0
[WARN ] Unknown min d_state for PCI: 00:13.2
[WARN ] Unknown min d_state for PCI: 00:1f.1
Change-Id: Iccaf26882ce5998469b2be6cf5bc7082f193cb29
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73071
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
| -rw-r--r-- | src/soc/intel/common/block/acpi/pep.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/soc/intel/common/block/acpi/pep.c b/src/soc/intel/common/block/acpi/pep.c index 0ba38c11af..b3150198ba 100644 --- a/src/soc/intel/common/block/acpi/pep.c +++ b/src/soc/intel/common/block/acpi/pep.c @@ -5,6 +5,7 @@ #include <assert.h> #include <commonlib/bsd/helpers.h> #include <console/console.h> +#include <device/pci_def.h> #include <intelblocks/acpi.h> #include <intelblocks/pmc_ipc.h> #include <stdlib.h> @@ -148,7 +149,8 @@ static enum acpi_device_sleep_states get_min_sleep_state( for (size_t i = 0; i < size; i++) if (states_arr[i].pci_dev == dev->path.pci.devfn) return states_arr[i].min_sleep_state; - printk(BIOS_WARNING, "Unknown min d_state for %x\n", dev->path.pci.devfn); + printk(BIOS_WARNING, "Unknown min d_state for PCI: 00:%02x.%01x\n", + PCI_SLOT(dev->path.pci.devfn), PCI_FUNC(dev->path.pci.devfn)); return ACPI_DEVICE_SLEEP_NONE; default: |