diff options
| author | Keith Hui <buurin@gmail.com> | 2020-04-19 16:03:24 -0400 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2020-05-17 14:19:15 +0000 |
| commit | 81f9ae9ff1122b25340b851c54a477c59d955048 (patch) | |
| tree | a34e2c5fef3e02e81125580170d78b14c4eebe01 | |
| parent | 99dbca381b10a25dabdeb7dd0a03c1a45449b472 (diff) | |
mb/asus/p2b: Remove variant validation guards from DSDT
With conversion to variant structure complete, remove temporary guards
inserted to help validate the move.
With this change, all P2B family boards (currently p2b and p2b-ls)
share the same S-state declarations.
TEST=No apparent ACPI regression observed on p2b-ls.
Change-Id: Ibd6e49adeae2a42800ee5bfd74b3850eb19843a5
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41051
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/mainboard/asus/p2b/dsdt.asl | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index d97299c1f6..c1ac5996c6 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -20,13 +20,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1) } /* - * For now only define 2 power states: - * - S0 which is fully on - * - S5 which is soft off - * Any others would involve declaring the wake up methods. - */ - - /* * Intel 82371EB (PIIX4E) datasheet, section 7.2.3, page 142 * * 0: soft off/suspend to disk S5 @@ -43,15 +36,9 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1) * 6: reserved * 7: reserved */ - /* Guard these entries for the purpose of variant validation. They will be aligned later. */ Name (\_S0, Package () { 0x05, 0x05, 0x00, 0x00 }) -#if CONFIG(BOARD_ASUS_P2B) Name (\_S1, Package () { 0x03, 0x03, 0x00, 0x00 }) Name (\_S5, Package () { 0x00, 0x00, 0x00, 0x00 }) -#endif -#if CONFIG(BOARD_ASUS_P2B_LS) - Name (\_S5, Package () { 0x00, 0x06, 0x00, 0x00 }) -#endif OperationRegion (GPOB, SystemIO, DEFAULT_PMBASE+DEVCTL, 0x10) Field (GPOB, ByteAcc, NoLock, Preserve) |